Page MenuHomeFreeBSD
Differential D26490

www/chromium: Make online detection always positive
ClosedPublic
Actions

Authored by khng on Sep 20 2020, 9:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 5:41 PM
Unknown Object (File)
Oct 4 2024, 3:54 AM
Unknown Object (File)
Oct 1 2024, 10:03 PM
Unknown Object (File)
Sep 29 2024, 9:28 PM
Unknown Object (File)
Sep 29 2024, 11:51 AM
Unknown Object (File)
Sep 28 2024, 10:32 PM
Unknown Object (File)
Sep 27 2024, 9:33 AM
Unknown Object (File)
Sep 19 2024, 6:03 PM
View All 30 Files
Subscribers
None

Details

Reviewers
jrm
lwhsu
Commits
rP557055: www/chromium: Synchronize with HEAD
rP555115: www/chromium: Make online detection always positive
Summary

navigator.onLine is currently broken in www/chromium. This change introduce a
workaround that always return positive for online detection.

Sponsored by: The FreeBSD Foundation

Test Plan

Tested with Slack and Skype.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng requested review of this revision.Sep 20 2020, 9:37 AM
khng created this revision.
Harbormaster completed remote builds in B33664: Diff 77246.Sep 20 2020, 9:37 AM
khng edited the summary of this revision. (Show Details)Sep 20 2020, 2:30 PM
khng edited the summary of this revision. (Show Details)Sep 20 2020, 2:34 PM
jrm added a comment.Sep 25 2020, 6:28 PM

Thanks for this. We are working through an update now and will get to this once that update is complete.

khng abandoned this revision.Nov 13 2020, 8:49 AM

Seems like it's fixed by ports.

khng reclaimed this revision.Nov 13 2020, 4:13 PM

Eh, seems the problem still persists on 85.0.4183.121_1

This revision was not accepted when it landed; it landed in state Needs Review.Nov 14 2020, 3:08 PM
Closed by commit rP555115: www/chromium: Make online detection always positive (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: rP555115: www/chromium: Make online detection always positive.
rene added a commit: rP557055: www/chromium: Synchronize with HEAD.Dec 7 2020, 10:19 AM

Revision Contents
Changeset List

PathSize
head/
www/
chromium/
2 lines
files/
18 lines

Diff 79548

View Options

head/www/chromium/Makefile

Loading...
View Options

head/www/chromium/files/patch-net_base_network__change__notifier.cc

Loading...