crunchgen(8): fix crunched application build with WARNS=6

[kevans]

Summary

This was revealed by the rescue build with a patch I'm working on to default WARNS=6 everywhere. The main issues were:

• Missing prototype for _crunched_${ident}_stub in the *_stub.c generated bits
• Missing prototype for crunched_main
• Incomplete prototype for _crunched_${ident}_stub in the generated parts of crunched_main
• Literal strings in the stub table must drop const qualifier, unless we const'ify name
• f field in struct stub didn't have a proper prototype

Most of these issues are minor formalities and easily addressed.

[arichardson]

LGTM. I probably wouldn't bother with the typedef and just add the parameters but don't mind either way.

usr.sbin/crunch/crunchgen/crunched_main.c

83 ↗

(On Diff #76783)

91 ↗

(On Diff #76783)

usr.sbin/crunch/crunchgen/crunchgen.c

938 ↗

(On Diff #76783)

[kevans]

In D26363#586262, @arichardson wrote:

LGTM. I probably wouldn't bother with the typedef and just add the parameters but don't mind either way.

I don't feel too strongly about the typedef, personally- I added it when I had this grand delusion of a header that I could eventually move it to so both crunched_main and the stub objects have a consistent idea of the signature. I realized that would be both silly and annoying, but kept the typedef to prove to myself consistency between the crunched_main signature and the entry point callbacks.