Page MenuHomeFreeBSD

Don't return errors from the cryptodev_process() method.
ClosedPublic

Authored by jhb on Sep 8 2020, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 12:04 AM
Unknown Object (File)
Thu, Jan 30, 9:26 AM
Unknown Object (File)
Fri, Jan 17, 5:08 PM
Unknown Object (File)
Fri, Jan 17, 2:56 AM
Unknown Object (File)
Tue, Jan 14, 10:56 PM
Unknown Object (File)
Nov 3 2024, 11:57 AM
Unknown Object (File)
Nov 3 2024, 11:56 AM
Unknown Object (File)
Nov 3 2024, 11:56 AM
Subscribers

Details

Summary

The cryptodev_process() method should either return 0 if it has
completed a request, or ERESTART to defer the request until later. If
a request encounters an error, the error should be reported via
crp_etype before completing the request via crypto_done().

Fix a few more drivers noticed by asomers@ similar to the fix in
r365389. This is an old bug, but went unnoticed since crypto requests
did not start failing as a normal part of operation until digest
verification was introduced which can fail requests with EBADMSG.

PR: 247986
Reported by: asomers

Test Plan
  • none yet, still need to compile test

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 8 2020, 4:51 PM
jhb added inline comments.
sys/dev/safe/safe.c
1262 ↗(On Diff #76777)

This is slightly different as we need to pass ERESTART to the caller.

This revision is now accepted and ready to land.Sep 8 2020, 5:44 PM