env to dso inits.
ClosedPublic
Actions

Authored by kib on Sep 7 2020, 11:39 AM.

Tags

None

Referenced Files

	F174933161: D26351.diff
	Wed, Oct 7, 1:35 AM

	F174931421: D26351.id.diff
	Wed, Oct 7, 1:21 AM

	F174916821: D26351.id76742.diff
	Tue, Oct 6, 11:13 PM

	Unknown Object (File)
	Thu, Oct 1, 5:33 AM

	Unknown Object (File)
	Fri, Sep 18, 11:05 PM

	Unknown Object (File)
	Fri, Sep 18, 10:24 PM

	Unknown Object (File)
	Fri, Sep 18, 6:07 PM

	Unknown Object (File)
	Sep 6 2026, 5:17 AM

View All Files

Subscribers

bdragon

imp

Details

Reviewers

emaste
dim

Commits

rS365432: rtld: pass argc/argv/env to dso inits.

Summary

This is consistent with how array inits are called, and also makes us more compatible with glibc environment.

Requested by: Alex S <iwtcex@gmail.com>
PR: 249162

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sep 7 2020, 11:39 AM

Herald added subscribers: bdragon, imp. · View Herald TranscriptSep 7 2020, 11:39 AM

Harbormaster completed remote builds in B33429: Diff 76734.Sep 7 2020, 11:39 AM

kib requested review of this revision.Sep 7 2020, 11:39 AM

emaste accepted this revision.Sep 7 2020, 6:02 PM

This revision is now accepted and ready to land.Sep 7 2020, 6:02 PM

LGTM, I don't see any downsides. I sort of feel like it's asymmetric that the arguments aren't passed to the fini functions, but glibc also doesn't do that. :)

Closed by commit rS365432: rtld: pass argc/argv/env to dso inits. (authored by kib). · Explain WhySep 7 2020, 9:32 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS365432: rtld: pass argc/argv/env to dso inits..

Revision Contents
Changeset List

Path

Size

head/

libexec/

rtld-elf/

rtld.c

2 lines

Diff 76742

View Options

head/libexec/rtld-elf/rtld.c

rtld: pass argc/argv/env to dso inits.ClosedPublicActions