Page MenuHomeFreeBSD

aw_clk_nm: fix incorrect use of abs()
ClosedPublic

Authored by avg on Sep 3 2020, 7:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 10:41 AM
Unknown Object (File)
Fri, Aug 28, 10:39 PM
Unknown Object (File)
Tue, Aug 25, 12:26 PM
Unknown Object (File)
Mon, Aug 24, 8:38 AM
Unknown Object (File)
Mon, Aug 24, 6:09 AM
Unknown Object (File)
Mon, Aug 24, 5:55 AM
Unknown Object (File)
Mon, Aug 24, 5:51 AM
Unknown Object (File)
Sat, Aug 22, 10:21 AM
Subscribers

Details

Summary

abs() takes a (signed) int as input.
Instead, it was used with unsigned 64-bit integers.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg requested review of this revision.Sep 3 2020, 7:37 AM

Thanks, I had no time to fix this.
abs is used on more clock drivers for allwinner so I think that adding the inline function to aw_clk.h would be better.

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

expose clk_freq_diff to other clk drivers

This revision is now accepted and ready to land.Sep 3 2020, 10:31 AM
This revision was automatically updated to reflect the committed changes.