Page MenuHomeFreeBSD

aw_clk_nm: fix incorrect use of abs()
ClosedPublic

Authored by avg on Sep 3 2020, 7:37 AM.

Details

Summary

abs() takes a (signed) int as input.
Instead, it was used with unsigned 64-bit integers.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

avg requested review of this revision.Sep 3 2020, 7:37 AM

Thanks, I had no time to fix this.
abs is used on more clock drivers for allwinner so I think that adding the inline function to aw_clk.h would be better.

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

expose clk_freq_diff to other clk drivers

This revision is now accepted and ready to land.Sep 3 2020, 10:31 AM
This revision was automatically updated to reflect the committed changes.