abs() takes a (signed) int as input.
Instead, it was used with unsigned 64-bit integers.
Details
Details
- Reviewers
manu mmel - Commits
- rS365395: aw_clk_nm: fix incorrect use of abs()
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks, I had no time to fix this.
abs is used on more clock drivers for allwinner so I think that adding the inline function to aw_clk.h would be better.
Comment Actions
If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!
Comment Actions
If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!
Comment Actions
If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!