Page MenuHomeFreeBSD
Differential D26287

umass: fix a leak in error case and enhance debugging
ClosedPublic
Actions

Authored by bz on Sep 1 2020, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:24 AM
Unknown Object (File)
May 5 2023, 3:15 AM
Subscribers
imp

Details

Reviewers
• hselasky
Commits
rS365335: umass: enhance debugging
rS365334: umass: fix a cam_sim leak in error case
Summary

Investigating a hang I found having some more error information
available would be helpful, so be more verbose and also tell cam/xpt
status in case of error/panic.

While chanign I noticed that in case of error in umass_cam_attach_sim()
we miss a cam_sim_free() call. Added that to not leak resources.

Reviewed by: ...
MFC after: 5 days
Test Plan

Not done like this; I have been running this with a direct printf and
not DPRINTF() though.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Sep 1 2020, 8:28 PM
bz created this revision.
Harbormaster completed remote builds in B33313: Diff 76512.Sep 1 2020, 8:28 PM
bz set the repository for this revision to rS FreeBSD src repository - subversion.Sep 1 2020, 8:30 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 1 2020, 8:30 PM
bz added a comment.Sep 1 2020, 9:16 PM

In case this is correct, should I commit the missing cam_sim_free() call on its own?

• hselasky accepted this revision.Sep 2 2020, 7:25 AM
• hselasky added inline comments.
sys/dev/usb/storage/umass.c
2110 ↗(On Diff #76512)

I wonder if you should unlock before doing cam_sim_free().

This revision is now accepted and ready to land.Sep 2 2020, 7:25 AM
bz added a comment.Sep 2 2020, 7:31 AM

Thanks!

sys/dev/usb/storage/umass.c
2110 ↗(On Diff #76512)

No, that's the locking guarantee cam_sim.c enforces.

Closed by commit rS365334: umass: fix a cam_sim leak in error case (authored by bz). · Explain WhySep 4 2020, 6:27 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rS365334: umass: fix a cam_sim leak in error case.
bz added a commit: rS365335: umass: enhance debugging.Sep 4 2020, 6:30 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
usb/
storage/
1 line

Diff 76659

View Options

head/sys/dev/usb/storage/umass.c

Loading...