Coverity claims the call to rdma_gid2ip in cma_igmp_send overwrites addr. Use a consistent definition of sockaddr to prevent detections and code changes in the future.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/ofed/include/rdma/ib_addr.h | ||
---|---|---|
63 ↗ | (On Diff #76341) | I believe you should add sockaddr_storage to the union, to get proper alignment. From what I see, sockaddr does not have any alignment requirements, and the strongest is sockaddr_in6 for 4 bytes. sockaddr_storage ensures 8 bytes when needed. |