Differential D26229

Appease Coverty
ClosedPublic
Actions

Authored by bret_ketchum_dell.com on Aug 29 2020, 4:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 1:14 AM

	Unknown Object (File)
	Sun, May 17, 7:13 PM

	Unknown Object (File)
	Mon, May 11, 3:36 PM

	Unknown Object (File)
	Fri, May 8, 7:31 PM

	Unknown Object (File)
	Sun, May 3, 7:04 PM

	Unknown Object (File)
	Fri, May 1, 10:46 PM

	Unknown Object (File)
	Wed, Apr 29, 9:47 PM

	Unknown Object (File)
	Tue, Apr 28, 4:27 AM

Subscribers

Details

Reviewers

• hselasky
vangyzen
kib

Commits

rS364997: infiniband: Appease Coverty

Summary

Coverity claims the call to rdma_gid2ip in cma_igmp_send overwrites addr. Use a consistent definition of sockaddr to prevent detections and code changes in the future.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bret_ketchum_dell.com requested review of this revision.Aug 29 2020, 4:19 PM

bret_ketchum_dell.com created this revision.

• hselasky added a reviewer: kib.Aug 29 2020, 7:22 PM

kib added inline comments.Aug 29 2020, 7:57 PM

sys/ofed/include/rdma/ib_addr.h
63 ↗	(On Diff #76341)	I believe you should add sockaddr_storage to the union, to get proper alignment. From what I see, sockaddr does not have any alignment requirements, and the strongest is sockaddr_in6 for 4 bytes. sockaddr_storage ensures 8 bytes when needed.

For future consistency sake.

kib accepted this revision.Aug 30 2020, 1:09 PM

This revision is now accepted and ready to land.Aug 30 2020, 1:09 PM

Don't forget to MFC to 11 and 12 stable.

Closed by commit rS364997: infiniband: Appease Coverty (authored by vangyzen). · Explain WhyAug 31 2020, 4:17 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rS364997: infiniband: Appease Coverty.

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2020, 4:17 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

ofed/

drivers/

infiniband/

core/

6 lines

11 lines

6 lines

include/

rdma/

7 lines

Diff 76419

head/sys/ofed/drivers/infiniband/core/ib_addr.c

Loading...

head/sys/ofed/drivers/infiniband/core/ib_cma.c

Loading...

head/sys/ofed/drivers/infiniband/core/ib_sa_query.c

Loading...

head/sys/ofed/include/rdma/ib_addr.h

Loading...