Page MenuHomeFreeBSD

Appease Coverty
ClosedPublic

Authored by bret_ketchum_dell.com on Aug 29 2020, 4:19 PM.

Details

Summary

Coverity claims the call to rdma_gid2ip in cma_igmp_send overwrites addr. Use a consistent definition of sockaddr to prevent detections and code changes in the future.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/ofed/include/rdma/ib_addr.h
63 ↗(On Diff #76341)

I believe you should add sockaddr_storage to the union, to get proper alignment.

From what I see, sockaddr does not have any alignment requirements, and the strongest is sockaddr_in6 for 4 bytes. sockaddr_storage ensures 8 bytes when needed.

This revision is now accepted and ready to land.Aug 30 2020, 1:09 PM

Don't forget to MFC to 11 and 12 stable.

This revision was automatically updated to reflect the committed changes.