Page MenuHomeFreeBSD
Differential D26219

who(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Aug 28 2020, 3:56 PM.
Tags
None
Referenced Files
F105759091: D26219.diff
Fri, Dec 20, 6:49 AM
Unknown Object (File)
Oct 9 2024, 1:06 PM
Unknown Object (File)
Oct 9 2024, 1:06 PM
Unknown Object (File)
Oct 9 2024, 1:06 PM
Unknown Object (File)
Sep 24 2024, 5:37 PM
Unknown Object (File)
Sep 22 2024, 1:49 PM
Unknown Object (File)
Sep 17 2024, 11:51 PM
Unknown Object (File)
Sep 7 2024, 1:15 PM
View All 37 Files
Subscribers
bcr
imp
Contributor Reviews (src)

Details

Reviewers
bcr
Group Reviewers
manpages
Commits
rS364977: who(1): Add EXAMPLES section
Summary

Add EXAMPLES section covering all the flags except -m and bTu covered by
other flags.

Test Plan
  • mandoc -Tlint clean
  • igor clean (spurious repeated root)
  • aspell happy
  • man ./who.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33215
Build 30558: arc lint + arc unit

Event Timeline

fernape created this revision.Aug 28 2020, 3:56 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 28 2020, 3:56 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Aug 28 2020, 3:56 PM
Harbormaster completed remote builds in B33212: Diff 76307.Aug 28 2020, 3:57 PM
bcr added a subscriber: bcr.Aug 28 2020, 5:01 PM

A few suggestions...

usr.bin/who/who.1
144

s/version/summary
You could also go with the description line from -q above...

151

I'd add: "(without the headers)" at the end to contrast it with the -H example.

fernape updated this revision to Diff 76314.Aug 28 2020, 6:01 PM

Address comments by bcr@

Harbormaster completed remote builds in B33215: Diff 76314.Aug 28 2020, 6:01 PM
fernape marked 2 inline comments as done.Aug 28 2020, 6:02 PM

Thanks for reviewing!

bcr accepted this revision.Aug 28 2020, 8:47 PM

Thank you for your constant supply of useful EXAMPLES.

Approved for commit!

This revision is now accepted and ready to land.Aug 28 2020, 8:47 PM
Closed by commit rS364977: who(1): Add EXAMPLES section (authored by fernape). · Explain WhyAug 30 2020, 5:41 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rS364977: who(1): Add EXAMPLES section.
fernape added a comment.Aug 30 2020, 5:43 PM
In D26219#582752, @bcr wrote:

Thank you for your constant supply of useful EXAMPLES.

Approved for commit!

Thanks for reviewing.
I have more EXAMPLES to add yet, but if you think of a specific man page you would like me to have a look at, just let me know!

Revision Contents
Changeset List

PathSize
usr.bin/
who/
43 lines

Diff 76314

View Options

usr.bin/who/who.1

Loading...