Page MenuHomeFreeBSD

Potential integer overflowing expression

Authored by on Aug 21 2020, 11:37 AM.



Coverity has identified the line in this change as "Potential integer overflowing expression" due to the variable i declared as an int and used in an expression with vm_paddr_t, a 64bit variable.

This change has very little effect as when this line is execute nkpt is small and phys_addr is a the beginning of physical memory. But there is no explicit protection that the above is true.

Test Plan

A kernel with this change boots reliably.

Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj added inline comments.
2114 ↗(On Diff #76053)

Per style(9) there should be no space in (vm_paddr_t)i.

This revision is now accepted and ready to land.Aug 21 2020, 1:56 PM