Page MenuHomeFreeBSD
Differential D26087

net80211: VHT correct NSS Set loop boundary
ClosedPublic
Actions

Authored by bz on Aug 17 2020, 4:59 PM.
Tags
None
Referenced Files
F169961094: D26087.id75907.diff
Thu, Sep 3, 2:54 AM
Unknown Object (File)
Tue, Sep 1, 8:48 PM
Unknown Object (File)
Tue, Sep 1, 8:36 PM
Unknown Object (File)
Tue, Sep 1, 8:33 PM
Unknown Object (File)
Tue, Sep 1, 8:13 PM
Unknown Object (File)
Thu, Aug 27, 5:30 PM
Unknown Object (File)
Thu, Aug 27, 10:01 AM
Unknown Object (File)
Wed, Aug 26, 10:44 AM
View All Files
Subscribers
gnn
imp
melifaro

Details

Reviewers
adrian
Group Reviewers
wireless
Commits
rS364326: net80211: VHT correct NSS Set loop boundary
Summary

For the <VHT-MCS, NSS> tuple, NSS is 1..8 (or in our loop case 0..7
but not 0..6). Correct the boundry to check for < 8 and not < 7.

MFC After: 2 weeks
Reviewed by:
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Aug 17 2020, 4:59 PM
Herald added a subscriber: melifaro. · View Herald TranscriptAug 17 2020, 4:59 PM
bz requested review of this revision.Aug 17 2020, 4:59 PM
Harbormaster completed remote builds in B33030: Diff 75896.Aug 17 2020, 4:59 PM
bz edited the summary of this revision. (Show Details)Aug 17 2020, 5:12 PM
adrian accepted this revision.Aug 17 2020, 5:45 PM

Oh yeah, good catch! We should also replace this with a define so we know how many max mcs streams is supported.

This revision is now accepted and ready to land.Aug 17 2020, 5:45 PM
Closed by commit rS364326: net80211: VHT correct NSS Set loop boundary (authored by bz). · Explain WhyAug 17 2020, 8:16 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rS364326: net80211: VHT correct NSS Set loop boundary.
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2020, 8:16 PM

Revision Contents
Changeset List

PathSize
head/
sys/
net80211/
2 lines

Diff 75907

View Options

head/sys/net80211/ieee80211_vht.c

Loading...