Page MenuHomeFreeBSD

Skip Linux madvise(MADV_DONTNEED) on unmanaged objects.
ClosedPublic

Authored by markj on Aug 17 2020, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 14 2024, 10:05 AM
Unknown Object (File)
Nov 30 2023, 3:14 PM
Unknown Object (File)
Sep 30 2023, 11:13 PM
Unknown Object (File)
Sep 27 2023, 3:01 AM
Unknown Object (File)
Aug 10 2023, 10:15 AM
Unknown Object (File)
Jun 15 2023, 7:42 AM
Unknown Object (File)
Jun 3 2023, 8:19 AM
Unknown Object (File)
May 14 2023, 6:57 PM
Subscribers

Details

Summary

I noticed this while reviewing the non-transparent superpages patch.
vm_object_madvise() is a no-op for unmanaged objects, but we should
limit the scope of mappings on which we'll call pmap_remove(). In
particular, with largepage objects we must remove mappings along
superpage boundaries.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Aug 17 2020, 1:06 PM
markj created this revision.

I do not object, but is there a way for linux process to ever mmap largepage ?

Hmm, perhaps freebsd process can shm_open, then pass fd to linux process over unix socket, and then linux process can mmap(fd) ?

This revision is now accepted and ready to land.Aug 17 2020, 3:57 PM
In D26084#579065, @kib wrote:

I do not object, but is there a way for linux process to ever mmap largepage ?

Hmm, perhaps freebsd process can shm_open, then pass fd to linux process over unix socket, and then linux process can mmap(fd) ?

That's what I was thinking. Or, maybe the fd can be inherited over execve(). I am not sure if the implicit O_CLOEXEC for shm objects can be cleared.