Page MenuHomeFreeBSD

Support multi-USE_GITHUB.
ClosedPublic

Authored by mat on May 21 2015, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 2:07 AM
Unknown Object (File)
Sat, Dec 21, 10:56 PM
Unknown Object (File)
Wed, Dec 18, 5:43 AM
Unknown Object (File)
Sat, Dec 14, 3:41 PM
Unknown Object (File)
Mon, Dec 9, 8:57 PM
Unknown Object (File)
Fri, Dec 6, 1:56 AM
Unknown Object (File)
Tue, Dec 3, 10:42 AM
Unknown Object (File)
Sat, Nov 30, 10:07 PM

Details

Reviewers
allanjude
bdrewery
Group Reviewers
portmgr
Summary

It follows the same grouping idea the MASTER_SITE* use.

PORTNAME=     bar
PORTVERSION=  1.0

USE_GITHUB= yes
GH_ACCOUNT= foo
GH_PROJECT= ${PORTNAME}-images:images

will end up doing:

$ make fetch-urlall-list MASTER_SITE_BACKUP=
https://codeload.github.com/foo/bar/tar.gz/1.0?dummy=/foo-bar-1.0_GH0.tar.gz
https://codeload.github.com/foo/bar-images/tar.gz/1.0?dummy=/foo-bar-images-1.0-1.0.tar.gz

The magic will generate variables:

  • DISTNAME_group the name of the distfile for that group, if, for example, it needs to be put in EXTRACT_ONLY, or something.
  • WRKSRC_group the directory the distfile for that group was extracted to, to move things around in after-extract.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mat retitled this revision from to First draft of multi github master site..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat edited edge metadata.

Handle defaults better, now:

PORTNAME=     bar
PORTVERSION=  1.0
USE_GITHUB= yes
GH_ACCOUNT= foo
GH_PROJECT= ${PORTNAME}-images:images

Will give:

$ make fetch-urlall-list MASTER_SITE_BACKUP=
https://codeload.github.com/foo/bar/tar.gz/1.0?dummy=/foo-bar-1.0_GH0.tar.gz
https://codeload.github.com/foo/bar-images/tar.gz/1.0?dummy=/foo-bar-images-1.0-1.0.tar.gz

Convert two ports as example.

Oh, bad me, an isc secret site had crept in.

Remove DISTVERSIONFULL from secondary distfiles, and add _GHX

Add another conversion.

Convert sysutils/consul, it can be done.

mat retitled this revision from First draft of multi github master site. to Support multi-USE_GITHUB..May 26 2015, 12:43 PM
bdrewery added a reviewer: bdrewery.
bdrewery added a subscriber: bdrewery.

I have not looked at the implementation too closely, but I like the usage. +1

This revision is now accepted and ready to land.May 27 2015, 3:19 PM

I have not looked at the implementation too closely, but I like the usage. +1

The implementation is simple, if unreadable, I parse the GH_* for groups, and generate DISTFILES/MASTER_SITES with the same groups, so that the fetching and extracting code works.

mat edited edge metadata.

Also provide DISTNAME_group variables so that they can be referenced in EXTRACT_ONLY, if the needs ever arises

This revision now requires review to proceed.May 27 2015, 3:45 PM
mat edited edge metadata.
mat updated this object.

Compare DISTVERSIONFULL with GH_TAGNAME, not the sanitized version, so that DISTVERSIONPREFIX=foo/ still works.

Add a new one, and add CHANGES

allanjude added inline comments.
CHANGES
16

It uses a grouping feature

17

either delete the word 'the', or add a word after explaining what those variables are 'the MASTER_SITES <something>'

19

"Some helpful variables are provided: WRKSRC_<group> for putting things in the right place in post-extract,
and DISTNAME_<group>/DISTFILE_<group> for use with EXTRACT_ONLY."

23

"A simple example:"

40

extract them to {$WRKDIR}

mat marked 4 inline comments as done.May 28 2015, 3:45 PM
allanjude added a reviewer: allanjude.

Only reviewed the CHANGES file

This revision is now accepted and ready to land.May 28 2015, 3:48 PM