Differential D26064

Check XHCI endpoint state before issuing XHCI endpoint commands
ClosedPublic
Actions

Authored by • hselasky on Aug 14 2020, 10:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 23, 6:43 PM

	Unknown Object (File)
	Sat, Jan 18, 10:17 PM

	Unknown Object (File)
	Sat, Jan 18, 10:08 PM

	Unknown Object (File)
	Sat, Jan 18, 6:24 AM

	Unknown Object (File)
	Sun, Jan 12, 10:53 PM

	Unknown Object (File)
	Dec 5 2024, 3:38 AM

	Unknown Object (File)
	Oct 22 2024, 8:25 AM

	Unknown Object (File)
	Oct 11 2024, 3:45 PM

View All 36 Files

Subscribers

Details

Reviewers

kp
bz

Commits

rS365240: MFC r364347:
rS365239: MFC r364347:
rS364347: Check the XHCI endpoint state before issuing XHCI endpoint commands.

Summary

Sponsored by: Mellanox Technologies

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• hselasky created this revision.Aug 14 2020, 10:07 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 14 2020, 10:07 AM

• hselasky requested review of this revision.Aug 14 2020, 10:07 AM

Harbormaster completed remote builds in B32987: Diff 75817.Aug 14 2020, 10:07 AM

bz accepted this revision.Aug 14 2020, 10:13 AM

bz added a subscriber: bz.

bz added inline comments.

sys/dev/usb/controller/xhci.c
3826 ↗	(On Diff #75817)	I assume it's fairly save to assume epno >= 1 here?

This revision is now accepted and ready to land.Aug 14 2020, 10:13 AM

• hselasky added inline comments.Aug 14 2020, 10:32 AM

sys/dev/usb/controller/xhci.c
3866 ↗	(On Diff #75817)	@bz : A value of zero is checked here.

• hselasky marked an inline comment as done.Aug 14 2020, 10:32 AM

pstef added a subscriber: pstef.Aug 14 2020, 10:41 AM

pstef added inline comments.

sys/dev/usb/controller/xhci.c
3826 ↗	(On Diff #75817)	Since it's checked somewhere else, maybe it'd be a good idea to put here an assertion?

Assert epno != 0.

This revision now requires review to proceed.Aug 14 2020, 10:47 AM

Harbormaster completed remote builds in B32990: Diff 75820.Aug 14 2020, 10:47 AM

bz accepted this revision.Aug 14 2020, 2:27 PM

This revision is now accepted and ready to land.Aug 14 2020, 2:27 PM

For what it's worth this doesn't fix the issues I'm seeing with a Corigine xHCI controller.
I wonder if it's worth adding explicit cases for ERROR (do nothing) and DISABLED (do nothing).

@kp: Feel free to comander this patch.

While not the fix for my problem I do believe this patch is correct, and aligns us better to the xHCI Endpoint State Diagram (xhci v1.1, 4.8.3 Endpoint Context State).

I believe my problem is that the state transitions for EP0 are different. Other OSs (Linux, NetBSD) simply skip the entire stop/set tr dequeue /... configure dance for EP0. This patch tries to do that for us: https://pastebin.com/hudthnUZ and does fix the issues I see with Corigine xHCI.

Closed by commit rS364347: Check the XHCI endpoint state before issuing XHCI endpoint commands. (authored by • hselasky). · Explain WhyAug 18 2020, 3:44 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS364347: Check the XHCI endpoint state before issuing XHCI endpoint commands..

• hselasky added a commit: rS365239: MFC r364347:.Sep 2 2020, 10:10 AM

• hselasky added a commit: rS365240: MFC r364347:.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

controller/

46 lines

Diff 75948

head/sys/dev/usb/controller/xhci.c

Loading...