libsa: smbios: Parse the chassis type and export it as smbios.chassis.type

[manu]

Summary

It can be useful to know what type of machine we are running on for desktop
related thing.
It also allow us to support all the DMI variable that linux driver can fetch.

Sponsored-by: The FreeBSD Foundation

[emaste]

Repeating setenv in each case seems a bit odd to me. Why not a variable or even a helper function that just does e.g. return ("Pizza Box") for each case?

[manu]

Use a helper function and do the setenv where the others setenv are done.

[emaste]

That's nicer, also you can now drop the break statements.

[manu]

In D26045#578148, @emaste wrote:

That's nicer, also you can now drop the break statements.

Yeah but doesn't some code analysis stuff warn on those ? (or maybe some cflags ...) that's the reason I've left them.

[imp]

stand/libsa/smbios.c

324

I'd think an array of these and a bound check would be better

[emaste]

Yeah but doesn't some code analysis stuff warn on those ? (or maybe some cflags ...) that's the reason I've left them.

Nah, it's a pretty common pattern and compilers/static analysis is smart enough. There are a ton of examples in contrib/elftoolchain/readelf/readelf.c

[emaste]

stand/libsa/smbios.c

324

That'd work, IMO either is equally fine.

[manu]

Commited as r364421