Small fixes in locore.S
ClosedPublic
Actions

Authored by mhorne on Aug 9 2020, 4:46 PM.

Tags

None

Referenced Files

	F82900009: D26016.diff
	Fri, May 3, 6:08 PM

	Unknown Object (File)
	Tue, Apr 30, 7:48 PM

	Unknown Object (File)
	Tue, Apr 30, 7:37 PM

	Unknown Object (File)
	Tue, Apr 30, 7:08 PM

	Unknown Object (File)
	Tue, Apr 30, 7:07 PM

	Unknown Object (File)
	Tue, Apr 30, 5:07 PM

	Unknown Object (File)
	Thu, Apr 18, 9:03 AM

	Unknown Object (File)
	Tue, Apr 16, 6:06 AM

View All 15 Files

Subscribers

imp

Details

Reviewers

jhb
jrtc27

Commits

rS364192: Small fixes in locore.S

Summary

Properly set up the frame pointer
Hang if we return from mi_startup
Whitespace

Test Plan

This is the root cause of the test case in D26015; our frame pointer was bogus.
This change also fixes that test case.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32890
Build 30292: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.Aug 9 2020, 4:46 PM

mhorne created this revision.

Harbormaster completed remote builds in B32890: Diff 75629.Aug 9 2020, 4:46 PM

jhb accepted this revision.Aug 12 2020, 8:41 PM

This revision is now accepted and ready to land.Aug 12 2020, 8:41 PM

jhb mentioned this in D26015: Check for invalid pc in unwind_frame.Aug 12 2020, 8:44 PM

Closed by commit rS364192: Small fixes in locore.S (authored by mhorne). · Explain WhyAug 13 2020, 2:17 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS364192: Small fixes in locore.S.

Herald added a subscriber: imp. · View Herald TranscriptAug 13 2020, 2:17 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

locore.S

23 lines

Diff 75629

View Options

Small fixes in locore.SClosedPublicActions