Page MenuHomeFreeBSD

uma: Check the full bucket cache before short-circuiting.
ClosedPublic

Authored by markj on Aug 6 2020, 7:01 PM.
Tags
None
Referenced Files
F103135107: D25980.diff
Thu, Nov 21, 11:28 AM
Unknown Object (File)
Mon, Nov 18, 5:21 AM
Unknown Object (File)
Oct 18 2024, 3:05 AM
Unknown Object (File)
Oct 18 2024, 2:41 AM
Unknown Object (File)
Oct 18 2024, 2:40 AM
Unknown Object (File)
Oct 3 2024, 11:26 AM
Unknown Object (File)
Oct 3 2024, 1:48 AM
Unknown Object (File)
Oct 1 2024, 4:27 AM
Subscribers

Details

Summary

The global bucketdisable flag indicates that we are in a low-memory
situation and should avoid allocating buckets. However, in the
allocation path we were checking it before the full bucket cache. Defer
the check so that we have a shot at allocating from the cache.

This came up because allocations from buf_trie_zone must always succeed.
In one scenario, all of the preallocated trie nodes were in the bucket
list, and a new slab allocation could not succeed due to a memory
shortage. The short-circuiting caused an allocation failure which
triggered a panic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable