Page MenuHomeFreeBSD

uma: Check the full bucket cache before short-circuiting.
ClosedPublic

Authored by markj on Aug 6 2020, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 4:27 AM
Unknown Object (File)
Tue, Oct 7, 3:08 AM
Unknown Object (File)
Mon, Oct 6, 8:02 AM
Unknown Object (File)
Sep 8 2025, 7:47 AM
Unknown Object (File)
Sep 2 2025, 9:55 AM
Unknown Object (File)
Aug 28 2025, 10:41 AM
Unknown Object (File)
Jul 31 2025, 2:32 PM
Unknown Object (File)
Jul 31 2025, 1:55 AM
Subscribers

Details

Summary

The global bucketdisable flag indicates that we are in a low-memory
situation and should avoid allocating buckets. However, in the
allocation path we were checking it before the full bucket cache. Defer
the check so that we have a shot at allocating from the cache.

This came up because allocations from buf_trie_zone must always succeed.
In one scenario, all of the preallocated trie nodes were in the bucket
list, and a new slab allocation could not succeed due to a memory
shortage. The short-circuiting caused an allocation failure which
triggered a panic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable