Page MenuHomeFreeBSD

uma: Check the full bucket cache before short-circuiting.
ClosedPublic

Authored by markj on Aug 6 2020, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 30, 10:28 PM
Unknown Object (File)
Thu, May 28, 8:30 PM
Unknown Object (File)
Thu, May 14, 2:24 PM
Unknown Object (File)
May 9 2026, 4:24 PM
Unknown Object (File)
Apr 23 2026, 12:28 PM
Unknown Object (File)
Apr 23 2026, 3:44 AM
Unknown Object (File)
Apr 23 2026, 12:49 AM
Unknown Object (File)
Apr 21 2026, 2:07 AM
Subscribers

Details

Summary

The global bucketdisable flag indicates that we are in a low-memory
situation and should avoid allocating buckets. However, in the
allocation path we were checking it before the full bucket cache. Defer
the check so that we have a shot at allocating from the cache.

This came up because allocations from buf_trie_zone must always succeed.
In one scenario, all of the preallocated trie nodes were in the bucket
list, and a new slab allocation could not succeed due to a memory
shortage. The short-circuiting caused an allocation failure which
triggered a panic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable