Page MenuHomeFreeBSD

uma: Check the full bucket cache before short-circuiting.
ClosedPublic

Authored by markj on Aug 6 2020, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 15, 4:53 AM
Unknown Object (File)
Tue, Sep 15, 4:47 AM
Unknown Object (File)
Tue, Sep 15, 4:44 AM
Unknown Object (File)
Thu, Sep 10, 4:16 PM
Unknown Object (File)
Thu, Sep 10, 12:53 PM
Unknown Object (File)
Thu, Sep 10, 12:50 AM
Unknown Object (File)
Sat, Sep 5, 8:00 PM
Unknown Object (File)
Sat, Sep 5, 3:49 AM
Subscribers

Details

Summary

The global bucketdisable flag indicates that we are in a low-memory
situation and should avoid allocating buckets. However, in the
allocation path we were checking it before the full bucket cache. Defer
the check so that we have a shot at allocating from the cache.

This came up because allocations from buf_trie_zone must always succeed.
In one scenario, all of the preallocated trie nodes were in the bucket
list, and a new slab allocation could not succeed due to a memory
shortage. The short-circuiting caused an allocation failure which
triggered a panic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable