ctfmerge: Fix missing pthread_cond_init()
ClosedPublic
Actions

Authored by arichardson on Aug 6 2020, 11:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 4, 4:52 PM

	Unknown Object (File)
	Sat, Jul 4, 1:30 AM

	Unknown Object (File)
	Thu, Jul 2, 10:45 PM

	Unknown Object (File)
	Thu, Jul 2, 8:54 PM

	Unknown Object (File)
	Wed, Jul 1, 1:58 AM

	Unknown Object (File)
	Tue, Jun 30, 10:26 PM

	Unknown Object (File)
	Fri, Jun 26, 11:39 PM

	Unknown Object (File)
	Thu, Jun 25, 12:37 AM

View All Files

Subscribers

imp

Details

Reviewers

brooks
markj
bdrewery

Commits

rS363991: ctfmerge: Fix missing pthread_cond_init()

Summary

This does not appear to matter on FreeBSD or Linux, but when building an
amd64 kernel on macOS I was seeing infinite loops in ctfmerge.
It turns out the loop in wip_save_work() was looping forever due to
pthread_cond_wait() always returning -EINVAL.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Aug 6 2020, 11:21 AM

arichardson created this revision.

Harbormaster completed remote builds in B32802: Diff 75484.Aug 6 2020, 11:21 AM

markj accepted this revision.Aug 6 2020, 2:01 PM

This revision is now accepted and ready to land.Aug 6 2020, 2:01 PM

brooks accepted this revision.Aug 6 2020, 7:27 PM

Closed by commit rS363991: ctfmerge: Fix missing pthread_cond_init() (authored by arichardson). · Explain WhyAug 6 2020, 8:45 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS363991: ctfmerge: Fix missing pthread_cond_init().

Herald added a subscriber: imp. · View Herald TranscriptAug 6 2020, 8:45 PM

Revision Contents
Changeset List

Path

Size

head/

cddl/

contrib/

opensolaris/

tools/

ctf/

cvt/

ctfmerge.c

1 line

Diff 75525

View Options

head/cddl/contrib/opensolaris/tools/ctf/cvt/ctfmerge.c

ctfmerge: Fix missing pthread_cond_init()ClosedPublicActions