Paths

Table of Contentst

Differential D25931

Allow bootstrapping pwd_mkdb on Linux/macOS
ClosedPublic
Actions

Authored by arichardson on Aug 3 2020, 2:50 PM.

Tags

None

Referenced Files

	F170484155: D25931.id75309.diff
	Sat, Sep 5, 1:13 AM

	Unknown Object (File)
	Thu, Sep 3, 12:37 AM

	Unknown Object (File)
	Sun, Aug 30, 12:11 AM

	Unknown Object (File)
	Tue, Aug 25, 2:53 PM

	Unknown Object (File)
	Tue, Aug 25, 2:52 PM

	Unknown Object (File)
	Tue, Aug 25, 1:40 PM

	Unknown Object (File)
	Mon, Aug 24, 3:33 PM

	Unknown Object (File)
	Sun, Aug 23, 4:31 PM

Subscribers

Details

Reviewers

emaste
jhb
brooks

Commits

rS363992: Allow bootstrapping pwd_mkdb on Linux/macOS

Summary

We need to provide a struct passwd that is compatible with the target
system and this is not the case when cross-building from macOS/Linux.
It should also be a problem when bootstrapping for an i386 target from a
FreeBSD amd64 host since time_t does not match across those systems.
However, pwd_mkdb always truncates integer values to 32-bit so this
difference does not result in different databases.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Aug 3 2020, 2:50 PM

arichardson created this revision.

Harbormaster completed remote builds in B32722: Diff 75309.Aug 3 2020, 2:50 PM

This seems fine.

usr.sbin/pwd_mkdb/pwd.h
61 ↗	(On Diff #75309)	Does this want to be `#include_next` instead?

This revision is now accepted and ready to land.Aug 3 2020, 5:45 PM

arichardson added inline comments.Aug 6 2020, 3:54 PM

usr.sbin/pwd_mkdb/pwd.h
61 ↗	(On Diff #75309)	Unfortunately that doesn't work. Using a relative path ensures that the file from ${SRCTOP}/include is used.

Closed by commit rS363992: Allow bootstrapping pwd_mkdb on Linux/macOS (authored by arichardson). · Explain WhyAug 6 2020, 8:46 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS363992: Allow bootstrapping pwd_mkdb on Linux/macOS.

Herald added a subscriber: imp. · View Herald TranscriptAug 6 2020, 8:46 PM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

pwd_mkdb/

3 lines

66 lines

Diff 75526

head/usr.sbin/pwd_mkdb/Makefile

Loading...

head/usr.sbin/pwd_mkdb/pwd.h

Loading...