Page MenuHomeFreeBSD

Enable use of the regulator in the Broadcom SDHCI controller
ClosedPublic

Authored by andrew on Jul 27 2020, 5:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 2:11 PM
Unknown Object (File)
Sun, Oct 12, 8:51 AM
Unknown Object (File)
Fri, Oct 10, 8:41 PM
Unknown Object (File)
Fri, Oct 10, 9:20 AM
Unknown Object (File)
Wed, Oct 8, 8:47 AM
Unknown Object (File)
Tue, Oct 7, 3:27 PM
Unknown Object (File)
Fri, Oct 3, 5:18 PM
Unknown Object (File)
Fri, Oct 3, 5:07 PM
Subscribers

Details

Summary

This will be needed before a future GPIO controller driver is added
as the later enaables regulators that leave the SDHCI controller
disabled.

Test Plan

Booted on Raspberry Pi 4

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove a newline that creped in

manu added inline comments.
sys/arm/broadcom/bcm2835/bcm2835_sdhci.c
176 ↗(On Diff #75016)

I don't think that you need this one.

Remove an extra mmc_helper

This revision is now accepted and ready to land.Jul 27 2020, 6:30 PM
manu requested changes to this revision.Jul 27 2020, 6:32 PM

Sorry, I've missed something
You need to change the mmcbr_update_ios in the kobj to point at the new one.

This revision now requires changes to proceed.Jul 27 2020, 6:32 PM
This revision is now accepted and ready to land.Jul 28 2020, 9:26 AM