Page MenuHomeFreeBSD

Enable use of the regulator in the Broadcom SDHCI controller
ClosedPublic

Authored by andrew on Mon, Jul 27, 5:39 PM.

Details

Summary

This will be needed before a future GPIO controller driver is added
as the later enaables regulators that leave the SDHCI controller
disabled.

Test Plan

Booted on Raspberry Pi 4

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

andrew created this revision.Mon, Jul 27, 5:39 PM
andrew requested review of this revision.Mon, Jul 27, 5:39 PM
andrew updated this revision to Diff 75016.Mon, Jul 27, 5:46 PM

Remove a newline that creped in

manu added a subscriber: manu.Mon, Jul 27, 6:08 PM
manu added inline comments.
sys/arm/broadcom/bcm2835/bcm2835_sdhci.c
176 ↗(On Diff #75016)

I don't think that you need this one.

andrew updated this revision to Diff 75017.Mon, Jul 27, 6:23 PM

Remove an extra mmc_helper

andrew marked an inline comment as done.Mon, Jul 27, 6:23 PM
manu accepted this revision.Mon, Jul 27, 6:30 PM
This revision is now accepted and ready to land.Mon, Jul 27, 6:30 PM
manu requested changes to this revision.Mon, Jul 27, 6:32 PM

Sorry, I've missed something
You need to change the mmcbr_update_ios in the kobj to point at the new one.

This revision now requires changes to proceed.Mon, Jul 27, 6:32 PM
andrew updated this revision to Diff 75045.Tue, Jul 28, 9:04 AM

Attach the _ios function

manu accepted this revision.Tue, Jul 28, 9:26 AM
This revision is now accepted and ready to land.Tue, Jul 28, 9:26 AM
This revision was automatically updated to reflect the committed changes.