Rewrite it in lua, even if it's small it's now sandboxed.
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
This was previously committed and reverted, it regresses ordering during deinstallation.
And this is not the same version as the one commited, I'll test the case in 246102 but I don't think that this an ordering problem.
Keywords/rmtry.ucl | ||
---|---|---|
6–8 | @rmtry only accepts one argument, no need to loop or split on spaces, just use %1. |
So ok, it changes stuff because lua scripts are executed after shell scripts.
Uses/gnome.mk put the @rmtry at the top of the plist.
I wonder how many shit like that exists in the ports tree ...
I'll find a way to make this work.
Keywords/rmtry.ucl | ||
---|---|---|
6–8 | I wasn't sure as the shell one used %@ and I didn't really looked but yes you're right. |
pkg now execute lua scripts first, so @bapt's version will be commited again once 1.15 is released.
https://github.com/freebsd/pkg/commit/5db007bf743fc4342e7232f9496089179c5a2e1f
Reopen now that pkg 1.15 is the minimal version needed.
I'll check again that this doesn't introduce problems.