Page MenuHomeFreeBSD

keywords: Rewrite rmtry in lua
Needs RevisionPublic

Authored by manu on Jul 21 2020, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 7:36 AM
Unknown Object (File)
Oct 3 2024, 9:02 PM
Unknown Object (File)
Oct 2 2024, 1:15 AM
Unknown Object (File)
Sep 27 2024, 12:52 AM
Unknown Object (File)
Sep 24 2024, 4:42 AM
Unknown Object (File)
Sep 22 2024, 5:05 AM
Unknown Object (File)
Sep 3 2024, 6:23 PM
Unknown Object (File)
Aug 25 2024, 2:50 PM
Subscribers

Details

Reviewers
bapt
antoine
mat
Group Reviewers
portmgr
Summary

Rewrite it in lua, even if it's small it's now sandboxed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu requested review of this revision.Jul 21 2020, 2:08 PM
antoine requested changes to this revision.Jul 21 2020, 3:12 PM
antoine added a subscriber: antoine.

This was previously committed and reverted, it regresses ordering during deinstallation.

This revision now requires changes to proceed.Jul 21 2020, 3:12 PM

This was previously committed and reverted, it regresses ordering during deinstallation.

And this is not the same version as the one commited, I'll test the case in 246102 but I don't think that this an ordering problem.

mat requested changes to this revision.Jul 21 2020, 3:27 PM
mat added inline comments.
Keywords/rmtry.ucl
6–8

@rmtry only accepts one argument, no need to loop or split on spaces, just use %1.

This was previously committed and reverted, it regresses ordering during deinstallation.

So ok, it changes stuff because lua scripts are executed after shell scripts.
Uses/gnome.mk put the @rmtry at the top of the plist.
I wonder how many shit like that exists in the ports tree ...
I'll find a way to make this work.

Keywords/rmtry.ucl
6–8

I wasn't sure as the shell one used %@ and I didn't really looked but yes you're right.

pkg now execute lua scripts first, so @bapt's version will be commited again once 1.15 is released.
https://github.com/freebsd/pkg/commit/5db007bf743fc4342e7232f9496089179c5a2e1f

Reopen now that pkg 1.15 is the minimal version needed.
I'll check again that this doesn't introduce problems.

This revision now requires changes to proceed.Oct 1 2020, 6:40 PM