Differential D25734

ipfw nat64 improve prefix length checks
ClosedPublic
Actions

Authored by 2khramtsov_gmail.com on Jul 19 2020, 9:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 22, 12:19 AM

	Unknown Object (File)
	Tue, Oct 21, 10:24 AM

	Unknown Object (File)
	Tue, Oct 21, 10:24 AM

	Unknown Object (File)
	Tue, Oct 21, 10:23 AM

	Unknown Object (File)
	Sat, Oct 18, 5:30 AM

	Unknown Object (File)
	Sat, Oct 18, 5:30 AM

	Unknown Object (File)
	Sat, Oct 18, 5:30 AM

	Unknown Object (File)
	Sat, Oct 18, 5:30 AM

Subscribers

lytboris_gmail.com

Contributor Reviews (src)

Details

Reviewers

Commits

rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted.

Summary

Improve prefix length checks in nat64clat and nat64stl.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

2khramtsov_gmail.com created this revision.Jul 19 2020, 9:41 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJul 19 2020, 9:41 PM

2khramtsov_gmail.com requested review of this revision.Jul 19 2020, 9:41 PM

fix spacing

Be consistent with other messages.
Sorry for notification spam.

2khramtsov_gmail.com retitled this revision from ipfw nat64clat fix segfault in clat prefix check to ipfw nat64clat fix segfault.Jul 19 2020, 11:29 PM

2khramtsov_gmail.com edited the summary of this revision. (Show Details)

2khramtsov_gmail.com retitled this revision from ipfw nat64clat fix segfault to ipfw nat64clat fix prefix length check.Jul 22 2020, 2:39 PM

2khramtsov_gmail.com edited the summary of this revision. (Show Details)

2khramtsov_gmail.com edited the test plan for this revision. (Show Details)

2khramtsov_gmail.com added a reviewer: ae.

2khramtsov_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

2khramtsov_gmail.com removed a subscriber: imp.

Same issue exists in stl instance. Could you please fix both of them in one hit?

sure

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 11:27 AM

Closed by commit rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted. (authored by ae). · Explain Why

This revision was automatically updated to reflect the committed changes.

ae added a commit: rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted..

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

4 lines

Diff 74664

sbin/ipfw/nat64clat.c

Loading...