Page MenuHomeFreeBSD
Differential D25734

ipfw nat64 improve prefix length checks
ClosedPublic
Actions

Authored by 2khramtsov_gmail.com on Jul 19 2020, 9:41 PM.
Tags
None
Referenced Files
F166028570: D25734.id75419.diff
Tue, Aug 11, 4:44 AM
Unknown Object (File)
Mon, Aug 10, 8:23 AM
Unknown Object (File)
Mon, Aug 10, 5:54 AM
Unknown Object (File)
Mon, Aug 10, 4:05 AM
Unknown Object (File)
Sun, Aug 9, 1:24 AM
Unknown Object (File)
Sat, Aug 8, 3:44 PM
Unknown Object (File)
Sat, Aug 8, 4:40 AM
Unknown Object (File)
Sat, Aug 8, 3:25 AM
View All Files
Subscribers
ae
lytboris_gmail.com
Contributor Reviews (src)

Details

Reviewers
ae
Commits
rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted.
Summary

Improve prefix length checks in nat64clat and nat64stl.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

2khramtsov_gmail.com created this revision.Jul 19 2020, 9:41 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJul 19 2020, 9:41 PM
2khramtsov_gmail.com requested review of this revision.Jul 19 2020, 9:41 PM
2khramtsov_gmail.com updated this revision to Diff 74669.Jul 19 2020, 10:22 PM
2khramtsov_gmail.com added a subscriber: ae.

fix spacing

2khramtsov_gmail.com updated this revision to Diff 74671.Jul 19 2020, 10:39 PM

Be consistent with other messages.
Sorry for notification spam.

2khramtsov_gmail.com retitled this revision from ipfw nat64clat fix segfault in clat prefix check to ipfw nat64clat fix segfault.Jul 19 2020, 11:29 PM
2khramtsov_gmail.com edited the summary of this revision. (Show Details)
2khramtsov_gmail.com retitled this revision from ipfw nat64clat fix segfault to ipfw nat64clat fix prefix length check.Jul 22 2020, 2:39 PM
2khramtsov_gmail.com edited the summary of this revision. (Show Details)
2khramtsov_gmail.com edited the test plan for this revision. (Show Details)
2khramtsov_gmail.com added a reviewer: ae.
2khramtsov_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
2khramtsov_gmail.com removed a subscriber: imp.
lytboris_gmail.com added a subscriber: lytboris_gmail.com.Aug 1 2020, 10:07 AM

Same issue exists in stl instance. Could you please fix both of them in one hit?

2khramtsov_gmail.com updated this revision to Diff 75247.Aug 1 2020, 10:37 AM
2khramtsov_gmail.com retitled this revision from ipfw nat64clat fix prefix length check to ipfw nat64 improve prefix length checks.
2khramtsov_gmail.com edited the summary of this revision. (Show Details)

sure

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 11:27 AM
Closed by commit rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted. (authored by ae). · Explain Why
This revision was automatically updated to reflect the committed changes.
ae added a commit: rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted..

Revision Contents
Changeset List

PathSize
sbin/
ipfw/
4 lines

Diff 74671

View Options

sbin/ipfw/nat64clat.c

Loading...