Page MenuHomeFreeBSD

Skip adding swap lines to /etc/fstab if swap is 0 sized
ClosedPublic

Authored by allanjude on May 16 2015, 11:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 1:49 PM
Unknown Object (File)
Mon, Nov 24, 7:20 PM
Unknown Object (File)
Sun, Nov 23, 12:40 AM
Unknown Object (File)
Fri, Nov 21, 5:56 AM
Unknown Object (File)
Thu, Nov 20, 9:18 PM
Unknown Object (File)
Fri, Nov 14, 1:15 PM
Unknown Object (File)
Fri, Nov 14, 10:28 AM
Unknown Object (File)
Fri, Nov 14, 10:28 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

allanjude retitled this revision from to Skip adding swap lines to /etc/fstab if swap is 0 sized.
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)

LGTM. But this is better reviewed by somebody who knows their way around bsdinstall. :)

eadler edited edge metadata.

this counts as mentor and src approval. Go ahead

This revision is now accepted and ready to land.May 17 2015, 12:52 AM
This revision was automatically updated to reflect the committed changes.
This revision is now accepted and ready to land.May 22 2015, 2:25 PM
allanjude edited edge metadata.

Fix syntax error found by Michael Dexter and Devin Teske

This revision now requires review to proceed.May 22 2015, 2:27 PM
dteske edited edge metadata.

Let "sh -n filename" be your friend, my friend ;D

In this case, the output of "sh -n zfsboot" was spot-on:
zfsboot: 979: Syntax error: "else" unexpected (expecting "then")

The proposed revision fixes the problem and I approve of this revision (adding "; then"). Thanks Allan.

This revision is now accepted and ready to land.May 22 2015, 3:33 PM