Page MenuHomeFreeBSD
Differential D25586

loader: setting vdev size based on label asize is not working
ClosedPublic
Actions

Authored by tsoome on Jul 7 2020, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 16, 4:53 AM
Unknown Object (File)
Thu, Apr 16, 3:01 AM
Unknown Object (File)
Tue, Apr 14, 12:35 PM
Unknown Object (File)
Tue, Apr 14, 8:48 AM
Unknown Object (File)
Tue, Apr 14, 5:33 AM
Unknown Object (File)
Fri, Apr 10, 5:04 PM
Unknown Object (File)
Thu, Apr 9, 10:43 AM
Unknown Object (File)
Thu, Apr 9, 2:49 AM
View All Files
Subscribers
allanjude
delphij
imp

Details

Reviewers
allanjude
Commits
rS363042: loader: setting vdev size based on label asize is not working
Summary

Because we need to read asize from vdev_tree. We also need to consider
different vdev type difference.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome created this revision.Jul 7 2020, 6:30 PM
Herald added a subscriber: delphij. · View Herald TranscriptJul 7 2020, 6:30 PM
tsoome requested review of this revision.Jul 7 2020, 6:30 PM
Harbormaster completed remote builds in B32183: Diff 74163.Jul 7 2020, 6:30 PM
allanjude accepted this revision.Jul 7 2020, 6:35 PM

Reviewed By: allanjude

This revision is now accepted and ready to land.Jul 7 2020, 6:35 PM
tsoome updated this revision to Diff 74176.Jul 7 2020, 10:50 PM

set asize to 0 on error

This revision now requires review to proceed.Jul 7 2020, 10:50 PM
Harbormaster completed remote builds in B32192: Diff 74176.Jul 7 2020, 10:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 1:19 PM
Closed by commit rS363042: loader: setting vdev size based on label asize is not working (authored by tsoome). · Explain Why
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rS363042: loader: setting vdev size based on label asize is not working.

Revision Contents
Changeset List

PathSize
head/
stand/
libsa/
zfs/
58 lines

Diff 74233

View Options

head/stand/libsa/zfs/zfsimpl.c

Loading...