loader: setting vdev size based on label asize is not working
ClosedPublic
Actions

Authored by tsoome on Jul 7 2020, 6:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 20, 5:51 PM

	Unknown Object (File)
	Wed, May 13, 11:08 PM

	Unknown Object (File)
	Wed, May 13, 10:03 AM

	Unknown Object (File)
	Sun, May 10, 6:12 AM

	Unknown Object (File)
	Sun, May 3, 12:07 AM

	Unknown Object (File)
	Sat, May 2, 3:03 AM

	Unknown Object (File)
	Fri, May 1, 11:55 PM

	Unknown Object (File)
	Wed, Apr 29, 11:34 AM

Subscribers

Details

Reviewers

allanjude

Commits

rS363042: loader: setting vdev size based on label asize is not working

Summary

Because we need to read asize from vdev_tree. We also need to consider
different vdev type difference.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Jul 7 2020, 6:30 PM

Herald added a subscriber: delphij. · View Herald TranscriptJul 7 2020, 6:30 PM

tsoome requested review of this revision.Jul 7 2020, 6:30 PM

Harbormaster completed remote builds in B32183: Diff 74163.Jul 7 2020, 6:30 PM

Reviewed By: allanjude

This revision is now accepted and ready to land.Jul 7 2020, 6:35 PM

set asize to 0 on error

This revision now requires review to proceed.Jul 7 2020, 10:50 PM

Harbormaster completed remote builds in B32192: Diff 74176.Jul 7 2020, 10:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 1:19 PM

Closed by commit rS363042: loader: setting vdev size based on label asize is not working (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rS363042: loader: setting vdev size based on label asize is not working.

Revision Contents
Changeset List

Path

Size

head/

stand/

libsa/

zfs/

zfsimpl.c

58 lines

Diff 74233

View Options

head/stand/libsa/zfs/zfsimpl.c

loader: setting vdev size based on label asize is not workingClosedPublicActions