Page MenuHomeFreeBSD

Rebuild sysent when capabilities.conf is updated.
ClosedPublic

Authored by markj on Jul 6 2020, 3:47 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Jul 6 2020, 3:47 PM
markj created this revision.

Huh, I thought we already did this. Did I inadvertently drop it when I consolidated?

Huh, I thought we already did this. Did I inadvertently drop it when I consolidated?

No idea. I just noticed the problem when updating capabilities.conf, I can't remember if this worked in the past.

sys/conf/sysent.mk
28 ↗(On Diff #74118)

This will work, but does cause some harmless rebuilds (e.g. things like linux combat that don't use capabilities.conf). I wonder if this should be added in the individual Makefiles.

sys/conf/sysent.mk
28 ↗(On Diff #74118)

I thought about it and went with this approach since:

  • the likelihood of a spurious rebuild is low, and it's harmless anyway
  • the makefile would be duplicating metadata from syscalls.conf

I'm happy to change it if you prefer, though.

brooks added inline comments.
sys/conf/sysent.mk
28 ↗(On Diff #74118)

It might be worth commenting that it's a known (unimportant) issue.

This revision is now accepted and ready to land.Jul 6 2020, 5:20 PM
markj marked an inline comment as done.

Add a comment about spurious rebuilds.

This revision now requires review to proceed.Jul 6 2020, 6:35 PM
This revision is now accepted and ready to land.Jul 6 2020, 6:48 PM
This revision was automatically updated to reflect the committed changes.