Page MenuHomeFreeBSD

riscv locore.S: load constant prior to loop
ClosedPublic

Authored by freebsdphab-AX9_cmx.ietfng.org on Jun 30 2020, 8:13 PM.

Details

Summary

A very minor micro-optimization; t0 is not clobbered between the loop top and bottom and there appear to be no other branches to this label.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mhorne added a subscriber: mhorne.

Hi, thank you for the patch. It looks good.

In the future, please upload diffs with full context. It makes them easier to review. To do so, run git show -U99999, or use the arcanist tool.

Could you confirm your name and email address for the "Submitted by:" tag in the commit?

Submitted by: Nathaniel Filardo <nwf20@cl.cam.ac.uk>
This revision is now accepted and ready to land.Jul 1 2020, 2:02 PM

Yes, that's a fine "Submitted by".

Thanks for the tip about full context.

This revision was automatically updated to reflect the committed changes.