Page MenuHomeFreeBSD

Update virtualbox to 5.2.42
Needs ReviewPublic

Authored by madpilot on Sun, Jun 28, 2:05 PM.

Details

Reviewers
jkim
Group Reviewers
vbox
Summary

This patch is baased on the one posted by Mario Lobo in bug 244212.

I have tested patches and regenerated them, two patches were also generating warnings which I cleaned up.

This also migrates the port to python3. Tested on my machine and it works, but firther testing is required, especially by people using the python interface.

I could not find any new CVEs for VirtualBox since 5.2.34, so I'm not touching vuln.xml.

Please if I'm mistaken regarding vulnerabilities please point me in the right direction.

Test Plan

This builds fine in poudriere with default options, also tested with all options enabled and all options disabled.

Works as well as 5.2.32 used to work for my virtual machines.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32045
Build 29572: arc lint + arc unit

Event Timeline

madpilot created this revision.Sun, Jun 28, 2:05 PM
madpilot requested review of this revision.Sun, Jun 28, 2:05 PM
lwhsu added a reviewer: jkim.Sun, Jun 28, 3:08 PM
lwhsu added a subscriber: lwhsu.Sun, Jun 28, 3:13 PM

I'm testing this on my machine now.

emulators/virtualbox-ose-additions/Makefile
6

I think this line can be removed.

emulators/virtualbox-ose/Makefile
6

So as this line.

143

Python 3.7 is the default version, maybe just use USE+=python ?

148

Same here.

madpilot updated this revision to Diff 73810.Sun, Jun 28, 3:35 PM

Allow any python version.

Suggested by: VVD in bug 244212

madpilot marked 2 inline comments as done.Sun, Jun 28, 3:36 PM

I noticed also your suggestion now, I have changed it to python without any specification.

madpilot planned changes to this revision.Sun, Jun 28, 3:37 PM
madpilot added inline comments.
emulators/virtualbox-ose-additions/Makefile
6

Right, I forgot about that.

madpilot updated this revision to Diff 73812.Sun, Jun 28, 3:38 PM

Removed commented out PORTREVISION lines.

madpilot marked 2 inline comments as done.Sun, Jun 28, 3:39 PM
lwhsu added a comment.Sun, Jun 28, 4:39 PM

DEVELOPER=yes in /etc/make.conf gives these after build:

Warning: 'lib/virtualbox/VBoxAuth.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxGuestControlSvc.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxRT.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxSharedClipboard.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxXPCOM.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxHostChannel.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/components/VBoxSVCM.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/components/VBoxC.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/components/VBoxXPCOMIPCC.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxNetDHCP.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxDD.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxXPCOMC.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxVMM.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/DbgPlugInDiggers.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxDragAndDropSvc.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxSharedCrOpenGL.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxDDU.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxHeadless.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxAuthSimple.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxGuestPropSvc.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxNetNAT.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxDD2.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxDbg.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxREM.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxVMMPreload.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VirtualBox.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxSharedFolders.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxSDL.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/virtualbox/VBoxKeyboard.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: Possible REINPLACE_CMD issues
sed failed: file content unchanged from backup: Config.kmk
sed failed: file content unchanged from backup: configure
sed failed: file content unchanged from backup: kBuild/header.kmk
sed failed: file content unchanged from backup: kBuild/units/qt4.kmk
sed failed: file content unchanged from backup: kBuild/units/qt5.kmk
sed failed: file content unchanged from backup: kBuild/sdks/LIBSDL.kmk
sed failed: file content unchanged from backup: src/libs/xpcom18a4/python/gen_python_deps.py
sed failed: file content unchanged from backup: src/VBox/Installer/freebsd/VBox.sh

Other than those, it works fine for me.

DEVELOPER=yes in /etc/make.conf gives these after build:

Looking at these they all look like issues already existing in the port before my patch.

Warning: 'lib/virtualbox/VBoxAuth.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}

[...]

Warning: 'lib/virtualbox/VBoxKeyboard.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}

I am testing stripping them with STRIP_CMD in post-install target. If it works well I'll update the patch set.

Warning: Possible REINPLACE_CMD issues
sed failed: file content unchanged from backup: Config.kmk
sed failed: file content unchanged from backup: configure
sed failed: file content unchanged from backup: kBuild/header.kmk
sed failed: file content unchanged from backup: kBuild/units/qt4.kmk
sed failed: file content unchanged from backup: kBuild/units/qt5.kmk
sed failed: file content unchanged from backup: kBuild/sdks/LIBSDL.kmk
sed failed: file content unchanged from backup: src/libs/xpcom18a4/python/gen_python_deps.py
sed failed: file content unchanged from backup: src/VBox/Installer/freebsd/VBox.sh

Some of these files are being modified with REINPLACE_CMD multiple times in post-patch, also because, depending on the options, different changes are needed.
Such multiple patching causes the backup to be overwritten, triggering false positives.

Some files are also targeted by a generic 's|/usr/local|${LOCALBASE}', and may actually not get modified if such lines have been removed from upstream sources in the while, but I'd leave the patch as is, since this is unharmful.

Other than those, it works fine for me.

Great!

madpilot updated this revision to Diff 73884.Mon, Jun 29, 8:49 PM

Add post-install command to strip internal binaries installed by this port.

madpilot edited the test plan for this revision. (Show Details)Mon, Jun 29, 8:50 PM