RB_SET_PARENT cannot be used as an expression
ClosedPublic
Actions

Authored by dougm on Jun 23 2020, 10:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 30, 2:30 PM

	Unknown Object (File)
	Tue, Apr 21, 6:17 PM

	Unknown Object (File)
	Apr 13 2026, 5:29 PM

	Unknown Object (File)
	Apr 6 2026, 11:51 AM

	Unknown Object (File)
	Apr 6 2026, 6:34 AM

	Unknown Object (File)
	Apr 3 2026, 5:13 AM

	Unknown Object (File)
	Apr 3 2026, 4:51 AM

	Unknown Object (File)
	Apr 2 2026, 5:30 PM

View All Files

Subscribers

emaste

imp

Details

Reviewers

markj
kib

Commits

rS362562: In r362552, RB_SET_PARENT is defined, and use in parens in

Summary

In r362552, RB_SET_PARENT is defined, and use in parens in RB_CLEAR_NODE. But it is not an expression, and ought not to be enclosed in parens. Remove them.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Jun 23 2020, 10:37 PM

Herald added a subscriber: emaste. · View Herald TranscriptJun 23 2020, 10:37 PM

dougm requested review of this revision.Jun 23 2020, 10:37 PM

markj accepted this revision.Jun 23 2020, 10:41 PM

This revision is now accepted and ready to land.Jun 23 2020, 10:41 PM

Closed by commit rS362562: In r362552, RB_SET_PARENT is defined, and use in parens in (authored by dougm). · Explain WhyJun 23 2020, 10:48 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS362562: In r362552, RB_SET_PARENT is defined, and use in parens in.

Herald added a subscriber: imp. · View Herald TranscriptJun 23 2020, 10:48 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

include/

linux/

rbtree.h

2 lines

Diff 73553

View Options

head/sys/compat/linuxkpi/common/include/linux/rbtree.h

RB_SET_PARENT cannot be used as an expressionClosedPublicActions