Page MenuHomeFreeBSD

Fix fallout from the emancipation of dump(8) workers
ClosedPublic

Authored by cperciva on Jun 22 2020, 8:37 PM.
Tags
None
Referenced Files
F114376615: D25403.id73475.diff
Fri, Apr 11, 9:23 PM
Unknown Object (File)
Tue, Mar 25, 12:34 PM
Unknown Object (File)
Feb 25 2025, 5:29 AM
Unknown Object (File)
Feb 25 2025, 12:03 AM
Unknown Object (File)
Feb 24 2025, 6:33 PM
Unknown Object (File)
Feb 23 2025, 7:46 PM
Unknown Object (File)
Feb 10 2025, 10:34 AM
Unknown Object (File)
Feb 9 2025, 10:57 AM
Subscribers

Details

Summary

The change from "slave" processes to "minion" processes to "worker" processes left some less-than-coherent names:

  1. "enslave" turned into the ungrammatical "enworker".
  2. "slp" (SLave Pointer) turned into "mlp" (Minion [L] Pointer?).

Convert "enworker" to "create_workers" (the function in question forks off 3 worker processes), and replace "mlp" with "wp" (Worker Pointer) and "tmlp" with "twp" (Temporary Worker Pointer).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva created this revision.

Thanks for taking care of this Colin. The diff looks fine at a quick glance.

Diff looks good to me, thanks. I would suggest not using "emancipation" in the commit subject.

This revision is now accepted and ready to land.Jun 22 2020, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Thanks for this cleanup. I found the previous transformation grating for the reasons that you listed.