Page MenuHomeFreeBSD

Fix fallout from the emancipation of dump(8) workers
ClosedPublic

Authored by cperciva on Jun 22 2020, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 10:10 AM
Unknown Object (File)
Sun, Oct 5, 4:10 AM
Unknown Object (File)
Mon, Sep 22, 8:25 AM
Unknown Object (File)
Sun, Sep 14, 6:05 AM
Unknown Object (File)
Aug 17 2025, 10:31 AM
Unknown Object (File)
Jul 28 2025, 2:21 PM
Unknown Object (File)
Jul 28 2025, 11:00 AM
Unknown Object (File)
Jul 28 2025, 3:13 AM
Subscribers

Details

Summary

The change from "slave" processes to "minion" processes to "worker" processes left some less-than-coherent names:

  1. "enslave" turned into the ungrammatical "enworker".
  2. "slp" (SLave Pointer) turned into "mlp" (Minion [L] Pointer?).

Convert "enworker" to "create_workers" (the function in question forks off 3 worker processes), and replace "mlp" with "wp" (Worker Pointer) and "tmlp" with "twp" (Temporary Worker Pointer).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva created this revision.

Thanks for taking care of this Colin. The diff looks fine at a quick glance.

Diff looks good to me, thanks. I would suggest not using "emancipation" in the commit subject.

This revision is now accepted and ready to land.Jun 22 2020, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Thanks for this cleanup. I found the previous transformation grating for the reasons that you listed.