Fixup plist owner/group/mode leackages.

[mat]

Summary

Make sure rc files are owned by root:wheel with a sensible mode.

A PLIST file is supposed to be self contained, reset owner/group/mode after each.

[mat]

reduce diff.

[mat]

Only do it if the file exists.

[bapt]

won't it be better to have a loop that appends things to PLIST_FILES?

[mat]

In D25295#557787, @bapt wrote:

won't it be better to have a loop that appends things to PLIST_FILES?

To have what loop? The USE_RC_SUBR one?

install-rc-script runs in the late install stage, whereas PLIST_FILES get handled early in generate-plist. Also, the USE_RC_SUBR loop is a shell loop, and you cannot add to a make variable in a shell loop ;-)

I do not think there would be any plus to it using PLIST_FILES. PLIST_FILES is a thing for porters to use in their ports. Inside the framework there are many many places adding things to TMPPLIST.

[mat]

Oh, sorry, I missread what you wrote, a new loop.

Well, we could have a loop adding the content of USE_RC_SUBR to PLIST_FILES. As you'd have to do quoting be able to add the string containing spaces, so that it does not get splitted later, I am not sure anything would be gained by it.

[bapt]

In D25295#557793, @mat wrote:

Oh, sorry, I missread what you wrote, a new loop.

Well, we could have a loop adding the content of USE_RC_SUBR to PLIST_FILES. As you'd have to do quoting be able to add the string containing spaces, so that it does not get splitted later, I am not sure anything would be gained by it.

my main point here is to have on single place to add things to ${TMPPLIST} but that is just an idea, no strong feeling here.

[swills]

Seems like a good idea to me.