Page MenuHomeFreeBSD
Differential D25257

Fix ldd for PIE binaries after rtld stopped accepting binaries for dlopen.
ClosedPublic
Actions

Authored by kib on Jun 13 2020, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 3, 11:10 PM
Unknown Object (File)
Thu, Sep 3, 4:21 PM
Unknown Object (File)
Wed, Sep 2, 10:54 PM
Unknown Object (File)
Wed, Sep 2, 8:32 PM
Unknown Object (File)
Sun, Aug 30, 2:25 PM
Unknown Object (File)
Sat, Aug 29, 3:48 AM
Unknown Object (File)
Fri, Aug 28, 11:10 PM
Unknown Object (File)
Fri, Aug 28, 11:09 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
dim
markj
Commits
rS362152: Fix ldd for PIE binaries after rtld stopped accepting binaries for dlopen.
Summary

ldd proclaims ET_DYN objects as shared libraries and tries to dlopen(RTLD_TRACE) them to get dependencies. Since PIE binaries are ET_DYN | DF_1_PIE, refusal to dlopen such binaries breaks ldd.

Fix it by reading and parsing dynamic segment looking for DF_FLAG_1 and taking DF_1_PIE into account when deciding between binary and library.

Reported by: Dewayne Geraghty <dewayne@heuristicsystems.com.au>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jun 13 2020, 3:30 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 13 2020, 3:30 PM
kib requested review of this revision.Jun 13 2020, 3:30 PM
Harbormaster completed remote builds in B31681: Diff 73070.Jun 13 2020, 3:30 PM
markj added inline comments.Jun 13 2020, 4:33 PM
usr.bin/ldd/ldd.c
377 ↗(On Diff #73070)

Why bother to do this work if e_type == ET_EXEC?

kib updated this revision to Diff 73074.Jun 13 2020, 4:45 PM
kib marked an inline comment as done.

Only parse dynamic for ET_DYN.

Harbormaster completed remote builds in B31685: Diff 73074.Jun 13 2020, 4:45 PM
markj accepted this revision.Jun 13 2020, 5:09 PM
This revision is now accepted and ready to land.Jun 13 2020, 5:09 PM
Closed by commit rS362152: Fix ldd for PIE binaries after rtld stopped accepting binaries for dlopen. (authored by kib). · Explain WhyJun 13 2020, 6:21 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS362152: Fix ldd for PIE binaries after rtld stopped accepting binaries for dlopen..

Revision Contents
Changeset List

PathSize
head/
usr.bin/
ldd/
79 lines

Diff 73082

View Options

head/usr.bin/ldd/ldd.c

Loading...