Hard-code the ice_ddp firmware version.
ClosedPublic
Actions

Authored by markj on Jun 10 2020, 11:49 PM.

Details

Reviewers

erj
imp

Commits

rS362038: Hard-code the ice_ddp firmware version.

Summary

Stop using find(1) in a makefile, and stop injecting a message into each
kernel build. When the firmware package is updated, update the makefile
as well. This is how every other firmware module works.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Jun 10 2020, 11:49 PM

markj created this revision.

Harbormaster completed remote builds in B31625: Diff 72956.Jun 10 2020, 11:49 PM

markj added a reviewer: erj.Jun 10 2020, 11:50 PM

imp accepted this revision.Jun 10 2020, 11:55 PM

This revision is now accepted and ready to land.Jun 10 2020, 11:55 PM

FWIW, it already needs to be updated by hand in sys/conf/files.(amd64,i386).

erj accepted this revision.Jun 10 2020, 11:59 PM

In D25222#556054, @brooks wrote:

FWIW, it already needs to be updated by hand in sys/conf/files.(amd64,i386).

I am just going to open-code the firmware version, then. The file version (1.3.9.0) and module version (0x01030900) are formatted differently, and both get duplicated into sys/conf.

Closed by commit rS362038: Hard-code the ice_ddp firmware version. (authored by markj). · Explain WhyJun 11 2020, 12:36 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS362038: Hard-code the ice_ddp firmware version..