Page MenuHomeFreeBSD

lang/ecl: Fix missing reference to SageMath
ClosedPublic

Authored by salvadore on Jun 7 2020, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 10:50 PM
Unknown Object (File)
Thu, Nov 28, 10:50 PM
Unknown Object (File)
Thu, Nov 28, 10:50 PM
Unknown Object (File)
Thu, Nov 28, 10:36 PM
Unknown Object (File)
Mon, Nov 25, 12:53 AM
Unknown Object (File)
Mon, Nov 18, 6:44 PM
Unknown Object (File)
Oct 31 2024, 4:19 PM
Unknown Object (File)
Oct 24 2024, 1:18 PM
Subscribers

Details

Summary

Add a reference to SageMath that was forgotten for a patch added with revision 537602.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

@thierry: Correct me if I am wrong, but I think you took that patch from https://git.sagemath.org/sage.git/tree/build/pkgs/ecl/patches/src/implib.patch .
It is probably useful to acknowledge SageMath, both for reference and for copyright (by the way, I am trusting you that we can add to the ports tree all the patches you borrowed -- both for ecl and for maxima -- without legal issues: I am not a lawyer and I have not checked).

You are right: I thought I had acknowledged SageMath everywhere, but missed this one.

SageMath is released under GPLv3, GPLv2 for Maxima and LGPL for ECL, and unless explicitly stated otherwise, patches are released under the same license.

Okay with me,

I am not familiar about the intricacies of the upstream projects - could those changes also be acceptable there?

This revision is now accepted and ready to land.Jun 11 2020, 5:33 PM

@gerald: Thanks!

We talked about pointy hats long time ago and I never had the occasion to wear one. If I remember correctly, it's the hat I can wear to make trivial commits without the need to wait for maintainer approval or maintainer timeout: can I wear one now?

@gerald: Thanks!

We talked about pointy hats long time ago and I never had the occasion to wear one. If I remember correctly, it's the hat I can wear to make trivial commits without the need to wait for maintainer approval or maintainer timeout: can I wear one now?

Nope, its that hat you wear, when you do that and it breaks the build additionally :P
https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/freebsd-glossary.html#pointyhat

@tcberner: Thanks! I wonder what I was trying to remember then.

@gerald: It must be it.

Do you think I can use a blanket approval here? The text you linked does not cover adding comments explicitely, but I guess that is not an exhausitive list. Moreover, I would found a bit absurd to mark a maintainer timeout for such a patch in case olgeni could not manage to look at it in time.

@gerald: It must be it.

Do you think I can use a blanket approval here?

By all means - every improvement is welcome :) kind of a “SageMath” blanket.

@olgeni: Thanks! I am going to commit it in a minute.

This revision was automatically updated to reflect the committed changes.