Page MenuHomeFreeBSD

Clean up the pci host generic driver
ClosedPublic

Authored by andrew on Jun 3 2020, 4:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 13, 6:53 PM
Unknown Object (File)
Sat, Jun 29, 12:33 AM
Unknown Object (File)
Wed, Jun 26, 2:31 PM
Unknown Object (File)
Mon, Jun 24, 12:36 PM
Unknown Object (File)
Sat, Jun 22, 9:43 AM
Unknown Object (File)
Sun, Jun 16, 5:04 AM
Unknown Object (File)
May 8 2024, 5:01 AM
Unknown Object (File)
May 8 2024, 4:40 AM

Details

Summary
  • Support Prefetchable Memory
  • Use the correct rman when allocating memory and ioports
  • Translate PCI addresses in bus_alloc_resource to allow physical addresses that are different than pci addresses.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31464
Build 29077: arc lint + arc unit

Event Timeline

andrew requested review of this revision.Jun 3 2020, 4:39 PM
andrew created this revision.

I am not an expert by any means but these changes look good to me.

This revision is now accepted and ready to land.Jun 13 2020, 12:33 AM
sys/dev/pci/pci_host_generic.c
364

Actually, another niggle I find while trying to adopt this patch today.

In pci_pci.c, when allocating the bridge window, we try to allocate start=0x0, end=0xfffff.

That's always going to fail if the pci memory range is [0xf8000000,0xfbffffff] (as in the case of the rpi controller). Somehow we need to adjust that bridge window region into a pci address range.

Also, it seems that we don't actually check if sc->ranges[i] is large enough to hold the requested [start, end] resource.

sys/dev/pci/pci_host_generic.c
364

Can you get the raw values of the PCIR_MEMBASE_1 and PCIR_MEMLIMIT_1 registers.

This revision was automatically updated to reflect the committed changes.