Page MenuHomeFreeBSD

Clean up the pci host generic driver
ClosedPublic

Authored by andrew on Jun 3 2020, 4:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 5:04 AM
Unknown Object (File)
May 8 2024, 5:01 AM
Unknown Object (File)
May 8 2024, 4:40 AM
Unknown Object (File)
May 8 2024, 4:40 AM
Unknown Object (File)
May 8 2024, 1:10 AM
Unknown Object (File)
Apr 30 2024, 9:50 PM
Unknown Object (File)
Apr 29 2024, 10:57 PM
Unknown Object (File)
Apr 27 2024, 2:05 AM

Details

Summary
  • Support Prefetchable Memory
  • Use the correct rman when allocating memory and ioports
  • Translate PCI addresses in bus_alloc_resource to allow physical addresses that are different than pci addresses.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Jun 3 2020, 4:39 PM
andrew created this revision.

I am not an expert by any means but these changes look good to me.

This revision is now accepted and ready to land.Jun 13 2020, 12:33 AM
sys/dev/pci/pci_host_generic.c
364 ↗(On Diff #72622)

Actually, another niggle I find while trying to adopt this patch today.

In pci_pci.c, when allocating the bridge window, we try to allocate start=0x0, end=0xfffff.

That's always going to fail if the pci memory range is [0xf8000000,0xfbffffff] (as in the case of the rpi controller). Somehow we need to adjust that bridge window region into a pci address range.

Also, it seems that we don't actually check if sc->ranges[i] is large enough to hold the requested [start, end] resource.

sys/dev/pci/pci_host_generic.c
364 ↗(On Diff #72622)

Can you get the raw values of the PCIR_MEMBASE_1 and PCIR_MEMLIMIT_1 registers.

This revision was automatically updated to reflect the committed changes.