Page MenuHomeFreeBSD

em(4): Add support for Comet Lake Mobile Platform, update shared code

Authored by on May 28 2020, 8:51 AM.



This change introduces Comet Lake Mobile Platform support in the e1000
driver along with shared code patches described below.

  • Cast return value of e1000_ltr2ns() to higher type to avoid overflow
  • Remove useless statement of assigning act_offset
  • Add initialization of identification LED
  • Fix flow control setup after connected standby After connected standby the driver blocks resets during "AdapterStart" and skips flow control setup. This change adds condition in e1000_setup_link_ich8lan() to always setup flow control and to setup physical interface only when there is no need to block resets.

Signed-off-by: Piotr Pietruszewski <>

Diff Detail

rS FreeBSD src repository - subversion
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erj added a subscriber: erj.
erj added inline comments.
5253 ↗(On Diff #72359)

There's extra whitespace here.

This revision is now accepted and ready to land.Jun 1 2020, 10:36 PM