Page MenuHomeFreeBSD
Differential D25035

em(4): Add support for Comet Lake Mobile Platform, update shared code
ClosedPublic
Actions

Authored by piotr.pietruszewski_intel.com on May 28 2020, 8:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 7:18 AM
Unknown Object (File)
Fri, Oct 17, 5:32 PM
Unknown Object (File)
Thu, Oct 16, 7:01 PM
Unknown Object (File)
Thu, Oct 16, 5:35 PM
Unknown Object (File)
Thu, Oct 16, 2:56 PM
Unknown Object (File)
Fri, Oct 10, 4:35 PM
Unknown Object (File)
Fri, Oct 10, 3:14 AM
Unknown Object (File)
Thu, Oct 9, 9:24 PM
View All Files
Subscribers
erj
imp

Details

Reviewers
erj
jeffrey.e.pieper_intel.com
Group Reviewers
Intel Networking
Commits
rS361805: em(4): Add support for Comet Lake Mobile Platform, update shared code
Summary

This change introduces Comet Lake Mobile Platform support in the e1000
driver along with shared code patches described below.

  • Cast return value of e1000_ltr2ns() to higher type to avoid overflow
  • Remove useless statement of assigning act_offset
  • Add initialization of identification LED
  • Fix flow control setup after connected standby After connected standby the driver blocks resets during "AdapterStart" and skips flow control setup. This change adds condition in e1000_setup_link_ich8lan() to always setup flow control and to setup physical interface only when there is no need to block resets.

Signed-off-by: Piotr Pietruszewski <piotr.pietruszewski@intel.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

piotr.pietruszewski_intel.com requested review of this revision.May 28 2020, 8:51 AM
piotr.pietruszewski_intel.com created this revision.
Harbormaster completed remote builds in B31345: Diff 72359.May 28 2020, 8:51 AM
piotr.pietruszewski_intel.com added a reviewer: Intel Networking.May 28 2020, 8:52 AM
erj accepted this revision as: erj.May 28 2020, 2:49 PM
erj added a subscriber: erj.
erj added inline comments.
sys/dev/e1000/e1000_ich8lan.c
5253 ↗(On Diff #72359)

There's extra whitespace here.

piotr.pietruszewski_intel.com updated this revision to Diff 72403.May 29 2020, 1:11 PM

Remove extra whitespace

Harbormaster completed remote builds in B31369: Diff 72403.May 29 2020, 1:12 PM
jeffrey.e.pieper_intel.com accepted this revision.Jun 1 2020, 10:36 PM
This revision is now accepted and ready to land.Jun 1 2020, 10:36 PM
erj accepted this revision.Jun 4 2020, 8:36 PM
Closed by commit rS361805: em(4): Add support for Comet Lake Mobile Platform, update shared code (authored by erj). · Explain WhyJun 4 2020, 8:39 PM
This revision was automatically updated to reflect the committed changes.
erj added a commit: rS361805: em(4): Add support for Comet Lake Mobile Platform, update shared code.
Herald added a subscriber: imp. · View Herald TranscriptJun 4 2020, 8:39 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
e1000/
7 lines
7 lines
5 lines
22 lines
7 lines

Diff 72684

View Options

head/sys/dev/e1000/e1000_api.c

Loading...
View Options

head/sys/dev/e1000/e1000_hw.h

Loading...
View Options

head/sys/dev/e1000/e1000_i210.c

Loading...
View Options

head/sys/dev/e1000/e1000_ich8lan.c

Loading...
View Options

head/sys/dev/e1000/if_em.c

Loading...