Page MenuHomeFreeBSD

Simpilfy RB_REMOVE
ClosedPublic

Authored by dougm on May 27 2020, 9:31 PM.
Tags
None
Referenced Files
F103585755: D25032.diff
Tue, Nov 26, 7:15 PM
Unknown Object (File)
Sep 27 2024, 1:25 PM
Unknown Object (File)
Sep 22 2024, 12:09 AM
Unknown Object (File)
Sep 21 2024, 6:38 PM
Unknown Object (File)
Sep 18 2024, 11:17 AM
Unknown Object (File)
Sep 2 2024, 2:29 AM
Unknown Object (File)
Sep 1 2024, 12:56 AM
Unknown Object (File)
Aug 26 2024, 8:13 PM
Subscribers

Details

Summary

RB_REMOVE invoke RB_REMOVE_COLOR either when child is red or child is null. In the first case, RB_REMOVE_COLOR just changes the child to black and returns. WIth this change, RB_REMOVE handles that case, and drops the child argument to RB_REMOVE_COLOR, since that value is always null.

RB_REMOVE_COLOR is changed to remove a couple of unneeded tests, and to eliminate some deep indentation.

RB_ISRED is defined to combine a null check with a test for redness, to replace that combination in several places.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.May 27 2020, 9:31 PM
dougm created this revision.

I ran stress2 tests for 39 hours with D25032.72341.diff, without seeing any problems

This revision is now accepted and ready to land.May 29 2020, 10:30 PM