Page MenuHomeFreeBSD

Replace fib6_lookup_nh_<ext|basic> calls with fib6_lookup.
ClosedPublic

Authored by melifaro on May 23 2020, 1:07 PM.

Details

Summary

fib6_lookup_nh_ represents pre-epoch generation of fib api,
providing less guarantees over pointer validness and requiring
on-stack data copying.

Conversion is straight-forwarded, as the only 2 differences are
requirement of running in network epoch and the need to handle
RTF_GATEWAY case in the caller code.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ae added inline comments.
sys/netinet6/ip6_output.c
1491 ↗(On Diff #72162)

I think it would be good to add NET_EPOCH_ASSERT() here.

This revision is now accepted and ready to land.May 25 2020, 8:36 AM