Page MenuHomeFreeBSD
Differential D24973

Replace fib6_lookup_nh_<ext|basic> calls with fib6_lookup.
ClosedPublic
Actions

Authored by melifaro on May 23 2020, 1:07 PM.

Details

Reviewers
ae
Group Reviewers
network
Commits
rS361573: Replace ip6_ouput fib6_lookup_nh_<ext|basic> calls with fib6_lookup().
Summary

fib6_lookup_nh_ represents pre-epoch generation of fib api,
providing less guarantees over pointer validness and requiring
on-stack data copying.

Conversion is straight-forwarded, as the only 2 differences are
requirement of running in network epoch and the need to handle
RTF_GATEWAY case in the caller code.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

melifaro created this revision.May 23 2020, 1:07 PM
Herald added subscribers: bz, ae, imp. · View Herald TranscriptMay 23 2020, 1:07 PM
melifaro requested review of this revision.May 23 2020, 1:07 PM
Harbormaster completed remote builds in B31254: Diff 72162.May 23 2020, 1:07 PM
ae accepted this revision as: ae.May 25 2020, 8:36 AM
ae added inline comments.
sys/netinet6/ip6_output.c
1491 ↗(On Diff #72162)

I think it would be good to add NET_EPOCH_ASSERT() here.

This revision is now accepted and ready to land.May 25 2020, 8:36 AM
Closed by commit rS361573: Replace ip6_ouput fib6_lookup_nh_<ext|basic> calls with fib6_lookup(). (authored by melifaro). · Explain WhyMay 28 2020, 7:29 AM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rS361573: Replace ip6_ouput fib6_lookup_nh_<ext|basic> calls with fib6_lookup()..

Revision Contents
Changeset List

PathSize
head/
sys/
netinet6/
46 lines

Diff 72355

View Options

head/sys/netinet6/ip6_output.c

Loading...