Page MenuHomeFreeBSD

pf: Add a new zone for per-table entry counters.
ClosedPublic

Authored by markj on May 14 2020, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 11, 8:11 PM
Unknown Object (File)
Wed, Mar 11, 4:31 AM
Unknown Object (File)
Tue, Mar 10, 4:33 PM
Unknown Object (File)
Tue, Mar 10, 6:23 AM
Unknown Object (File)
Tue, Mar 10, 1:16 AM
Unknown Object (File)
Mon, Mar 9, 3:55 AM
Unknown Object (File)
Sun, Mar 8, 8:55 AM
Unknown Object (File)
Sat, Mar 7, 11:48 AM

Details

Summary

Right now we allocate 2*PFR_OP_ADDR_MAX*OP_DIR_MAX counters per table
entry, which itself requires 8 pointers. We can instead define a zone
which returns arrays of 8 per-CPU counters, so the table entry structure
only needs to store one pointer.

On amd64 this reduces sizeof(pfr_kentry) from 216 to 160. The smaller
size also gets us better slab efficiency (i.e., there is less internal
fragmentation): we can pack 25 structures in a page instead of 18.
vm.uma.pf_table_entries.keg.efficiency goes from 94% to 97%.

Test Plan

pf regression tests pass

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable