Differential D24796

linuxkpi: add pci_dev_present and an srcu function for drm5.2
ClosedPublic
Actions

Authored by ashafer on May 10 2020, 2:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 31, 5:37 AM

	Unknown Object (File)
	Wed, Jan 29, 8:26 PM

	Unknown Object (File)
	Sat, Jan 25, 7:49 PM

	Unknown Object (File)
	Sat, Jan 25, 7:23 PM

	Unknown Object (File)
	Fri, Jan 24, 7:00 PM

	Unknown Object (File)
	Fri, Jan 24, 5:18 PM

	Unknown Object (File)
	Sun, Jan 5, 1:00 AM

	Unknown Object (File)
	Thu, Jan 2, 4:53 PM

View All 82 Files

Subscribers

Details

Reviewers

• hselasky
manu

Commits

rS361246: linuxkpi: add pci_dev_present

Summary

These functions are needed for building drm5.2. They should not
introduce any known backwards compatability issues.

pci_dev_present shows if a set of pci ids are present in the system.
It just wraps pci_find_device.

synchronize_srcu_expedited likewise wraps the existing synchronize_src
lkpi function.

Test Plan

Tested with drm5.2 wip on Intel UHD 605.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashafer created this revision.May 10 2020, 2:20 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMay 10 2020, 2:20 PM

ashafer requested review of this revision.May 10 2020, 2:20 PM

Harbormaster completed remote builds in B31012: Diff 71611.May 10 2020, 2:20 PM

• hselasky added inline comments.May 10 2020, 3:01 PM

sys/compat/linuxkpi/common/include/linux/pci.h
1056 ↗	(On Diff #71611)	style: while (cur != NULL &&
1058 ↗	(On Diff #71611)	BSD style: return (1);
1062 ↗	(On Diff #71611)	Ditto.
sys/compat/linuxkpi/common/include/linux/srcu.h
52 ↗	(On Diff #71611)	Commit this change separately.

Sorry my style habits are taking a little while to form.

I'll make a new review for the srcu changes in a moment.

Harbormaster completed remote builds in B31014: Diff 71616.May 10 2020, 5:09 PM

manu accepted this revision.May 16 2020, 10:25 AM

This revision is now accepted and ready to land.May 16 2020, 10:25 AM

Closed by commit rS361246: linuxkpi: add pci_dev_present (authored by manu). · Explain WhyMay 19 2020, 8:44 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS361246: linuxkpi: add pci_dev_present.

manu mentioned this in rS364654: MFC r361007, r361138-r361140, r361245-r361246.Aug 24 2020, 10:46 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

include/

linux/

12 lines

Diff 71979

head/sys/compat/linuxkpi/common/include/linux/pci.h

Loading...