Page MenuHomeFreeBSD

add binutils dependency for as
Needs ReviewPublic

Authored by emaste on May 6 2020, 8:42 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

/usr/bin/as will be removed for FreeBSD 13.0

Exp-run PR 205250

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste requested review of this revision.May 6 2020, 8:42 PM
emaste created this revision.
emaste retitled this revision from add dependency on as for objdump to add binutils dependency for as.May 6 2020, 9:09 PM
lwhsu added a subscriber: lwhsu.May 7 2020, 5:16 AM
lwhsu added a comment.May 7 2020, 5:19 AM

PORTREVISION needs increasing.

emaste added a subscriber: bapt.May 7 2020, 6:16 PM

PORTREVISION needs increasing.

I asked @bapt about it and this should be a nop if as already exists (libxine notwithstanding) so bump not necessary - agreed?

multimedia/libxine/Makefile
19

oops, should be as:devel/binutils

lwhsu added a comment.EditedMay 7 2020, 6:24 PM

PORTREVISION needs increasing.

I asked @bapt about it and this should be a nop if as already exists (libxine notwithstanding) so bump not necessary - agreed?

Agree. I was also on the fence of bumping it or not. It is nop for non-CURRENT branches. I was afraid that a -CURRENT user installed them before as removed from the base, and then it becomes unusable, and because there is no newer version of the port so they will not know the extra dependency needs installing. I think this case is somehow rare and the -CURRENT users should have knowledge to fix them by updating ports tree and reinstall them.

emaste added a comment.May 7 2020, 6:29 PM

PORTREVISION needs increasing.

I asked @bapt about it and this should be a nop if as already exists (libxine notwithstanding) so bump not necessary - agreed?

Agree. I was also on the fence of bumping it or not. It is nop for non-CURRENT branches. I was afraid that a -CURRENT user installed them before as removed from the base, and then it becomes unusable, and because there is no newer version of the port so they will not know the extra dependency needs installing. I think this case is somehow rare and the -CURRENT users should have knowledge to fix them by updating ports tree and reinstall them.

Its also a nop on -CURRENT at the moment because as isn't removed just yet.

emaste added a subscriber: bofh.May 7 2020, 6:30 PM
emaste added subscribers: dinoex, olgeni, acm.
lwhsu added a comment.May 7 2020, 6:34 PM

Its also a nop on -CURRENT at the moment because as isn't removed just yet.

Oh, right, it is BUILD_DEPENDS not RUN_ so it won't affect installed ones.

acm added a comment.May 7 2020, 7:13 PM

is it replacing USE_BINUTILS? lang/fpc has it into Makefile file

emaste added a comment.May 7 2020, 7:42 PM
In D24739#544699, @acm wrote:

is it replacing USE_BINUTILS? lang/fpc has it into Makefile file

Hmm, I think if USE_BINUTILS is already there no change should be needed. Is it possible USE_BINUTILS was added after the last exp-run (which was some time ago)? Let me try building without any change.

emaste added a comment.EditedMay 7 2020, 7:56 PM

Hmm, I think if USE_BINUTILS is already there no change should be needed. Is it possible USE_BINUTILS was added after the last exp-run (which was some time ago)? Let me try building without any change.

hrm, with as removed and no change to lang/fpc/Makefile I get

===>   fpc-3.0.4_4 depends on file: /usr/local/bin/as - not found
*** Error code 1

USE_BINUTILS adds BUILD_DEPENDS+= ${LOCALBASE}/bin/as:devel/binutils so I'm not sure what's happening.

swills added a subscriber: swills.May 20 2020, 4:23 PM