add binutils dependency for as

[emaste]

Summary

/usr/bin/as will be removed for FreeBSD 13.0

Exp-run PR 205250

[lwhsu]

PORTREVISION needs increasing.

[emaste]

In D24739#544504, @lwhsu wrote:

PORTREVISION needs increasing.

I asked @bapt about it and this should be a nop if as already exists (libxine notwithstanding) so bump not necessary - agreed?

multimedia/libxine/Makefile

19

oops, should be as:devel/binutils

[lwhsu]

In D24739#544688, @emaste wrote:

In D24739#544504, @lwhsu wrote:

PORTREVISION needs increasing.

I asked @bapt about it and this should be a nop if as already exists (libxine notwithstanding) so bump not necessary - agreed?

Agree. I was also on the fence of bumping it or not. It is nop for non-CURRENT branches. I was afraid that a -CURRENT user installed them before as removed from the base, and then it becomes unusable, and because there is no newer version of the port so they will not know the extra dependency needs installing. I think this case is somehow rare and the -CURRENT users should have knowledge to fix them by updating ports tree and reinstall them.

[emaste]

In D24739#544691, @lwhsu wrote:

In D24739#544688, @emaste wrote:

In D24739#544504, @lwhsu wrote:

PORTREVISION needs increasing.

I asked @bapt about it and this should be a nop if as already exists (libxine notwithstanding) so bump not necessary - agreed?

Agree. I was also on the fence of bumping it or not. It is nop for non-CURRENT branches. I was afraid that a -CURRENT user installed them before as removed from the base, and then it becomes unusable, and because there is no newer version of the port so they will not know the extra dependency needs installing. I think this case is somehow rare and the -CURRENT users should have knowledge to fix them by updating ports tree and reinstall them.

Its also a nop on -CURRENT at the moment because as isn't removed just yet.

[lwhsu]

In D24739#544692, @emaste wrote:

Its also a nop on -CURRENT at the moment because as isn't removed just yet.

Oh, right, it is BUILD_DEPENDS not RUN_ so it won't affect installed ones.

[acm]

is it replacing USE_BINUTILS? lang/fpc has it into Makefile file

[emaste]

In D24739#544699, @acm wrote:

is it replacing USE_BINUTILS? lang/fpc has it into Makefile file

Hmm, I think if USE_BINUTILS is already there no change should be needed. Is it possible USE_BINUTILS was added after the last exp-run (which was some time ago)? Let me try building without any change.

[emaste]

Hmm, I think if USE_BINUTILS is already there no change should be needed. Is it possible USE_BINUTILS was added after the last exp-run (which was some time ago)? Let me try building without any change.

hrm, with as removed and no change to lang/fpc/Makefile I get

===>   fpc-3.0.4_4 depends on file: /usr/local/bin/as - not found
*** Error code 1

USE_BINUTILS adds BUILD_DEPENDS+= ${LOCALBASE}/bin/as:devel/binutils so I'm not sure what's happening.

[emaste]

exp-run in PR205250

[emaste]

/usr/bin/as has been removed, presumably all issues have been addressed