Page MenuHomeFreeBSD

add Mk/Uses/objdump.mk to handle objdump removal from the base system
AbandonedPublic

Authored by emaste on May 6 2020, 3:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 11:01 AM
Unknown Object (File)
Dec 23 2023, 2:21 AM
Unknown Object (File)
Jul 12 2023, 7:41 AM
Unknown Object (File)
Jun 12 2023, 2:05 PM
Unknown Object (File)
May 20 2023, 2:49 PM
Unknown Object (File)
Jan 9 2023, 6:03 AM
Unknown Object (File)
Dec 12 2022, 10:52 PM
Subscribers

Details

Reviewers
adamw
Group Reviewers
portmgr
Summary

I intend to remove /usr/bin/objdump shortly - see PR 229046. @adamw suggested doing this via Uses/objdump.mk

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.May 6 2020, 3:32 AM
emaste created this revision.
Mk/Uses/objdump.mk
7

cribbed this from readline; I don't know that it's necessary (for any existing cases) but it doesn't hurt to have it available.

19

I suppose we could have objdump:build to be explicit about a build dependency, but if there is a port that has a runtime dependency on objdump IMO we should make that port depend on binutils on all versions rather than having different runtime behaviour by FreeBSD version - objdump 2.17.50 is quite limited compared to contemporary GNU objdump

I'll need a review and explicit approval from a ports committer (as I do not have a ports bit) - please add an explicit "Approved by" tag once we have a committable version.

I am not sure this needs a USES, this is a 1 line dependency. (BUILD_DEPENDS+=objdump:devel/binutils or USE_BINUTILS=yes)

I agree with @antoine a USES is probably not necessary at all here.

That's fine; I originally thought it'd be fine to unconditionally add the dependency and just bring in binutils on all FreeBSD releases, but did it this way on request not to bring along the dependency when not required.

but did it this way on request not to bring along the dependency when not required.

Oh wait, making the dependency BUILD_DEPENDS+=/usr/bin/objdump:devel/binutils would DTRT?