emulators/i386-wine: Update to 5.0
ClosedPublic
Actions

Authored by salvadore on Apr 30 2020, 1:16 PM.

Details

Reviewers

gerald
tcberner

Commits

rP533808: emulators/i386-wine: Update to 5.0

Summary

Update to 5.0 and forward emulators/wine-devel improvements from revisions r528784, r533164 and r533267. In particular, fix bug #244547.

PR: 244547, 244368

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

salvadore created this revision.Apr 30 2020, 1:16 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 30 2020, 1:16 PM

salvadore requested review of this revision.Apr 30 2020, 1:16 PM

Harbormaster completed remote builds in B30807: Diff 71181.Apr 30 2020, 1:16 PM

As you might remember, we agreed that I would have updated i386-wine-devel before forwarding improvements to i386-wine and updating it. However, the updating process of i386-wine-devel introduced a bug: since I do not know how much time I will need to fix it, in the meantime, I thought we can bring i386-wine up to date.

@gerald: Feel free to update wine-devel to next release when it's the moment. It might be that the bug just disappears automatically with 5.8.

I forgot to add that I have already tested the patch successfully.

In D24631#542198, @salvadore wrote:

I forgot to add that I have already tested the patch successfully.

Well, that is my general assumption :)

In D24631#542368, @tcberner wrote:

In D24631#542198, @salvadore wrote:

I forgot to add that I have already tested the patch successfully.

Well, that is my general assumption :)

Indeed I always test carefully, but in this case I wanted to state it explicitly to confirm that this patch is working even if something is wrong with the update for i386-wine-devel.

salvadore edited the summary of this revision. (Show Details)May 1 2020, 12:18 PM

I forgot to forward the detail about minimal OSVERSION supported for 13.0-CURRENT. Fixed.

Harbormaster completed remote builds in B30886: Diff 71344.May 3 2020, 7:37 PM

This is great progress. i386-wine never even went to Wine 4.x, so this is a big jump from 3.x to the new 5.0.

This revision is now accepted and ready to land.May 3 2020, 8:14 PM

salvadore edited the summary of this revision. (Show Details)May 3 2020, 8:36 PM

Closed by commit rP533808: emulators/i386-wine: Update to 5.0 (authored by salvadore). · Explain WhyMay 3 2020, 8:37 PM

This revision was automatically updated to reflect the committed changes.

salvadore added a commit: rP533808: emulators/i386-wine: Update to 5.0.