Page MenuHomeFreeBSD

math/wxmaxima: Update to 20.04.0
ClosedPublic

Authored by salvadore on Apr 26 2020, 11:38 AM.

Details

Summary
  • Add an option to install a German manual page.
  • Resolved a crash on right-clicking a GroupCell.
  • View/Invert worksheet brightness now toggles an instant dark worksheet mode.
  • Removed an unnecessary info dialogue on startup.
  • Right-click-suggestions for similar command names.
  • Corrected the initial slideshow size.
  • A more stable language selection mechanism.
  • An Ukrainian translation update.
  • A Russian translation update.
  • Help works again in the German translation.
  • Extended the "fitting data" example.
  • An example on how to iterate through lists efficiently.
  • Many spelling corrections and better formulations.
  • A big number of small bug-fixes
  • A noticeable speed up.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I don't get why this is an option. Why not simply install it?

I don't get why this is an option. Why not simply install it?

I thought an option was better because not everybody can read German, and even German people might be fine with the English manual page only.
Should I drop the option and install the file in any case?

I would either include it by default (it's a file, it won't be 10G big...) or reuse the NLS option.

I don't get why this is an option. Why not simply install it?

I also wondered when reviewing the patch and was going to respond "Why the GERMAN option? Did you want to give ${OPTION}_EXTRA_PATCHES_OFF a try? ;-)"

I thought an option was better because not everybody can read German, and even German people might be fine with the English manual page only.
Should I drop the option and install the file in any case?

Your logic makes sense in principle, Lorenzo, and your approach is not bad or flawed.

There is just a balance between complexity for developers on the one hand, admins using our ports/packages on the other, and end users on the third. By adding such an option we increase complexity for the maintainer/possibly other committers (even adding an additional patch file and doubling the testing matrix), admins installing the port, and end users would then not get the German man page if installed from our default packages.

Which options to offer via our ports, and which of those are on by default, always is a balance and judgement call, involving user feedback and personal preferences, finding a good spot between being extremely opinionated and overwhelmung our users.

Hope this makes sense?

I approve your patch without the introduction of the GERMAN option (or with if you have strong reasons).

This revision is now accepted and ready to land.Apr 26 2020, 1:34 PM

I would either include it by default (it's a file, it won't be 10G big...) or reuse the NLS option.

Yep. (Sorry, I had not seen this comment before sending my longer response.)

Thanks mentors for your comments!
I understand your arguments and I agree: I will remove the option, thus installing the file by default.

This revision was automatically updated to reflect the committed changes.