Submitted by: Yang Wang <2333@outlook.jp>
Sponsored by: The FreeBSD Foundation
Details
Details
- Reviewers
kevans - Commits
- rS360877: Add pkgbase METALOG parse/check tool
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think this is otherwise good as a first pass.
| tools/pkgbase/metalog_reader.lua | ||
|---|---|---|
| 3 ↗ | (On Diff #70960) | This should go after the copyright header, as we do in C |
| 5 ↗ | (On Diff #70960) | We've leaned towards not having multi-line/block comments thus far, but this might be OK for copyright header. |
| 35 ↗ | (On Diff #70960) | As in our C style, if we're going to wrap then the operator should appear just before the wrap, rather than just after. |
| 42–43 ↗ | (On Diff #70960) | I somewhat wonder if we shouldn't try to pull argparse into base, or write a quick-n-dirty getopt(3) shim for lua. |
Comment Actions
Thanks for the comments - I've updated the version in my tree, and will commit to tools/ soon. We can iterate on it from there.
| tools/pkgbase/metalog_reader.lua | ||
|---|---|---|
| 42–43 ↗ | (On Diff #70960) | Yeah, that sounds like a good idea |