Page MenuHomeFreeBSD

Add pkgbase METALOG diagnostic tool
ClosedPublic

Authored by emaste on Apr 24 2020, 8:43 PM.
Tags
None
Referenced Files
F106650991: D24563.diff
Fri, Jan 3, 9:37 AM
Unknown Object (File)
Thu, Dec 5, 8:08 AM
Unknown Object (File)
Sep 22 2024, 2:32 PM
Unknown Object (File)
Sep 21 2024, 2:44 PM
Unknown Object (File)
Sep 20 2024, 1:50 PM
Unknown Object (File)
Sep 10 2024, 12:14 AM
Unknown Object (File)
Sep 10 2024, 12:14 AM
Unknown Object (File)
Sep 10 2024, 12:14 AM
Subscribers

Details

Summary

Submitted by: Yang Wang <2333@outlook.jp>
Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I think this is otherwise good as a first pass.

tools/pkgbase/metalog_reader.lua
3

This should go after the copyright header, as we do in C

5

We've leaned towards not having multi-line/block comments thus far, but this might be OK for copyright header.

35

As in our C style, if we're going to wrap then the operator should appear just before the wrap, rather than just after.

42–43

I somewhat wonder if we shouldn't try to pull argparse into base, or write a quick-n-dirty getopt(3) shim for lua.

Thanks for the comments - I've updated the version in my tree, and will commit to tools/ soon. We can iterate on it from there.

tools/pkgbase/metalog_reader.lua
42–43

Yeah, that sounds like a good idea

This revision was not accepted when it landed; it landed in state Needs Review.May 10 2020, 4:11 PM
This revision was automatically updated to reflect the committed changes.