Page MenuHomeFreeBSD
Differential D24540

Update blake2 accelerated software tests to work after OCF refactoring.
ClosedPublic
Actions

Authored by jhb on Apr 22 2020, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 8, 9:40 PM
Unknown Object (File)
Wed, May 6, 11:15 PM
Unknown Object (File)
Mon, May 4, 2:41 PM
Unknown Object (File)
Mon, May 4, 7:57 AM
Unknown Object (File)
Sat, May 2, 3:41 AM
Unknown Object (File)
Fri, May 1, 9:18 PM
Unknown Object (File)
Fri, May 1, 11:32 AM
Unknown Object (File)
Thu, Apr 30, 8:11 AM
View All Files
Subscribers
cem
imp

Details

Reviewers
lwhsu
jmg
cem
Commits
rS360203: Update blake2 accelerated software tests to work after OCF refactoring.
Summary
  • Lookup device drivers to test by name instead of assuming that the software / hardware flags will select specific drivers.
  • Set the sysctl to permit software /dev/crypto requests when testing the accelerated software blake2 driver.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Apr 22 2020, 7:27 PM
Herald added a reviewer: jmg. · View Herald TranscriptApr 22 2020, 7:27 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B30671: Diff 70890.Apr 22 2020, 7:27 PM
cem accepted this revision.Apr 22 2020, 7:34 PM
cem added a subscriber: cem.
cem added inline comments.
tests/sys/opencrypto/blake2_test.c
149 ↗(On Diff #70890)

I’d prefer to do the lookup_crid on a statement of its own. Just a style nit.

This revision is now accepted and ready to land.Apr 22 2020, 7:34 PM
jhb updated this revision to Diff 70892.Apr 22 2020, 7:46 PM
jhb marked an inline comment as done.
  • Move lookup_crid to separate lines.
This revision now requires review to proceed.Apr 22 2020, 7:46 PM
Harbormaster completed remote builds in B30672: Diff 70892.Apr 22 2020, 7:46 PM
cem accepted this revision.Apr 22 2020, 7:50 PM

Thanks!

This revision is now accepted and ready to land.Apr 22 2020, 7:50 PM
lwhsu accepted this revision.Apr 22 2020, 7:52 PM

Verified tests pass after applying the patch.

Closed by commit rS360203: Update blake2 accelerated software tests to work after OCF refactoring. (authored by jhb). · Explain WhyApr 22 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS360203: Update blake2 accelerated software tests to work after OCF refactoring..

Revision Contents
Changeset List

PathSize
head/
tests/
sys/
opencrypto/
37 lines

Diff 70894

View Options

head/tests/sys/opencrypto/blake2_test.c

Loading...