Page MenuHomeFreeBSD

Update blake2 accelerated software tests to work after OCF refactoring.
ClosedPublic

Authored by jhb on Apr 22 2020, 7:27 PM.

Details

Summary
  • Lookup device drivers to test by name instead of assuming that the software / hardware flags will select specific drivers.
  • Set the sysctl to permit software /dev/crypto requests when testing the accelerated software blake2 driver.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem added a subscriber: cem.
cem added inline comments.
tests/sys/opencrypto/blake2_test.c
149 ↗(On Diff #70890)

I’d prefer to do the lookup_crid on a statement of its own. Just a style nit.

This revision is now accepted and ready to land.Apr 22 2020, 7:34 PM
jhb marked an inline comment as done.
  • Move lookup_crid to separate lines.
This revision now requires review to proceed.Apr 22 2020, 7:46 PM
This revision is now accepted and ready to land.Apr 22 2020, 7:50 PM

Verified tests pass after applying the patch.