Factor code in LinuxKPI to allow attach and detach to and from any BSD device
ClosedPublic
Actions

Authored by • hselasky on Apr 20 2020, 7:09 PM.

Details

Reviewers

np
manu

Commits

rS360526: MFC r360196:
rS360196: Factor code in LinuxKPI to allow attach and detach using any BSD device.

Summary

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• hselasky created this revision.Apr 20 2020, 7:09 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptApr 20 2020, 7:09 PM

Harbormaster completed remote builds in B30631: Diff 70810.Apr 20 2020, 7:09 PM

Update function naming.

Harbormaster completed remote builds in B30632: Diff 70811.Apr 20 2020, 7:11 PM

This doesn't quite work because I can't have a struct pci_dev in the softc of the device, which has a native BSD driver (cxgbe) and doesn't use linuxkpi. A different module (iw_cxgbe) on top of cxgbe deals with OFED and that uses linuxkpi. With all this in mind I made the following changes on top of this revision:
https://people.freebsd.org/~np/lkpi_pci.diff

What do you think? If you're ok with my changes please incorporate them into this review.

These are the driver changes I used for testing:
https://people.freebsd.org/~np/iw_cxgbe_dma_device.diff

This revision now requires changes to proceed.Apr 21 2020, 10:56 PM

Incorporate Navdeeps changes.

Can you use this version?

Harbormaster completed remote builds in B30659: Diff 70867.Apr 22 2020, 7:03 AM

This isn't the exact change I'd suggested or tested but it looks ok to me.

This revision is now accepted and ready to land.Apr 22 2020, 7:22 AM

Closed by commit rS360196: Factor code in LinuxKPI to allow attach and detach using any BSD device. (authored by • hselasky). · Explain WhyApr 22 2020, 2:33 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS360196: Factor code in LinuxKPI to allow attach and detach using any BSD device..

• hselasky added a commit: rS360526: MFC r360196:.May 1 2020, 9:50 AM