Fix -Wvoid-pointer-to-enum-cast warnings.
ClosedPublic
Actions

Authored by brooks on Apr 14 2020, 10:21 PM.

Details

Reviewers

dim
arichardson

Commits

rS363050: MFC r362979:
rS363048: MFC r362979:
rS362979: Fix a Wvoid-pointer-to-enum-cast warning missed in r359978.
rS360415: MFC r359978:
rS360414: MFC r359978:
rS359978: Fix -Wvoid-pointer-to-enum-cast warnings.

Summary

This pattern is used in callbacks with void * data arguments and seems
both relatively uncommon and relatively harmless. Silence the warning
casting through uintptr_t.

This warning is on by default in Clang 11.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Apr 14 2020, 10:21 PM

Herald added a subscriber: melifaro. · View Herald TranscriptApr 14 2020, 10:21 PM

Harbormaster completed remote builds in B30506: Diff 70579.Apr 14 2020, 10:21 PM

LGTM. I'll remove the -Wno-error=void-pointer-to-enum-cast CheriBSD change once this is merged.

This revision is now accepted and ready to land.Apr 14 2020, 10:58 PM

Closed by commit rS359978: Fix -Wvoid-pointer-to-enum-cast warnings. (authored by brooks). · Explain WhyApr 15 2020, 6:16 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS359978: Fix -Wvoid-pointer-to-enum-cast warnings..

Herald added a subscriber: imp. · View Herald TranscriptApr 15 2020, 6:16 PM

brooks added a commit: rS360414: MFC r359978:.Apr 27 2020, 11:47 PM

brooks added a commit: rS360415: MFC r359978:.

brooks added a commit: rS362979: Fix a Wvoid-pointer-to-enum-cast warning missed in r359978..Jul 6 2020, 10:40 PM

brooks added a commit: rS363048: MFC r362979:.Jul 9 2020, 4:59 PM

brooks added a commit: rS363050: MFC r362979:.Jul 9 2020, 5:12 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

gen/

getgrent.c

16 lines

getpwent.c

16 lines

net/

6 lines

6 lines

6 lines

18 lines

rpc/

getrpcent.c

14 lines

sys/

dev/

ocs_fc/

ocs_device.c

2 lines

net80211/

ieee80211_output.c

2 lines

Diff 70613

View Options

head/lib/libc/gen/getgrent.c

View Options

head/lib/libc/gen/getpwent.c

View Options

head/lib/libc/net/gethostnamadr.c

View Options

head/lib/libc/net/getnetnamadr.c

View Options

head/lib/libc/net/getprotoent.c

View Options

head/lib/libc/net/getservent.c

View Options

head/lib/libc/rpc/getrpcent.c

View Options

head/sys/dev/ocs_fc/ocs_device.c

View Options

head/sys/net80211/ieee80211_output.c

Fix -Wvoid-pointer-to-enum-cast warnings.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 70613

head/lib/libc/gen/getgrent.c

head/lib/libc/gen/getpwent.c

head/lib/libc/net/gethostnamadr.c

head/lib/libc/net/getnetnamadr.c

head/lib/libc/net/getprotoent.c

head/lib/libc/net/getservent.c

head/lib/libc/rpc/getrpcent.c

head/sys/dev/ocs_fc/ocs_device.c

head/sys/net80211/ieee80211_output.c

Fix -Wvoid-pointer-to-enum-cast warnings.
ClosedPublic
Actions

Revision Contents
Changeset List